hollalinux
/
linux-sg2042
mirror of https://github.com/sophgo/linux-riscv.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

PCI: Free resource files in error path of pci_create_sysfs_dev_files() 

pci_create_sysfs_dev_files() should call pci_remove_resource_files() in
its error path, to match the call it makes to pci_create_resource_files().

Signed-off-by: Michael Ellerman <michael@ellerman.id.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This commit is contained in:
Michael Ellerman 2007-04-18 13:34:12 +10:00 committed by Greg Kroah-Hartman
parent c0affe9db4
commit 9890b12a4a
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/pci/pci-sysfs.c
View File

@ -636,7 +636,7 @@ int __must_check pci_create_sysfs_dev_files (struct pci_dev *pdev)
goto err_rom; goto err_rom;
} else { } else {
retval = -ENOMEM; retval = -ENOMEM;
goto err_bin_file; goto err_resource_files;
} }
} }
/* add platform-specific attributes */ /* add platform-specific attributes */
@ -646,6 +646,8 @@ int __must_check pci_create_sysfs_dev_files (struct pci_dev *pdev)
err_rom: err_rom:
kfree(rom_attr); kfree(rom_attr);
err_resource_files:
pci_remove_resource_files(pdev);
err_bin_file: err_bin_file:
if (pdev->cfg_size < 4096) if (pdev->cfg_size < 4096)
sysfs_remove_bin_file(&pdev->dev.kobj, &pci_config_attr); sysfs_remove_bin_file(&pdev->dev.kobj, &pci_config_attr);