hollalinux
/
linux-sg2042
mirror of https://github.com/sophgo/linux-riscv.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

usb: dwc3: gadget: hold the lock through set_wedge()'s life 

Instead of releasing the lock and calling locked
versions of our set_halt() methods, let's hold
the lock all the way through and call unlocked
versions of those functions.

Signed-off-by: Felipe Balbi <balbi@ti.com>
This commit is contained in:
Felipe Balbi 2014-09-24 10:50:14 -05:00
parent 5ad02fb813
commit 95aa4e8d65
1 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
drivers/usb/dwc3/gadget.c
View File

@ -1257,15 +1257,18 @@ static int dwc3_gadget_ep_set_wedge(struct usb_ep *ep)
struct dwc3_ep *dep = to_dwc3_ep(ep); struct dwc3_ep *dep = to_dwc3_ep(ep);
struct dwc3 *dwc = dep->dwc; struct dwc3 *dwc = dep->dwc;
unsigned long flags; unsigned long flags;
int ret;
spin_lock_irqsave(&dwc->lock, flags); spin_lock_irqsave(&dwc->lock, flags);
dep->flags |= DWC3_EP_WEDGE; dep->flags |= DWC3_EP_WEDGE;
spin_unlock_irqrestore(&dwc->lock, flags);
if (dep->number == 0 || dep->number == 1) if (dep->number == 0 || dep->number == 1)
return dwc3_gadget_ep0_set_halt(ep, 1); ret = __dwc3_gadget_ep0_set_halt(ep, 1);
else else
return dwc3_gadget_ep_set_halt(ep, 1); ret = __dwc3_gadget_ep_set_halt(dep, 1);
spin_unlock_irqrestore(&dwc->lock, flags);
return ret;
} }
/* -------------------------------------------------------------------------- */ /* -------------------------------------------------------------------------- */