hollalinux
/
linux-sg2042
mirror of https://github.com/sophgo/linux-riscv.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

USB: serial: cp210x: return early on unchanged termios 

Return early from set_termios() in case no relevant terminal settings
have changed.

This avoids testing each parameter in turn and specifically allows the
line-control handling to be cleaned up further.

Signed-off-by: Johan Hovold <johan@kernel.org>
This commit is contained in:
Johan Hovold 2020-11-16 17:18:21 +01:00
parent 053af9e6e8
commit 95168d624f
1 changed files with 12 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
drivers/usb/serial/cp210x.c
View File

@ -1352,6 +1352,15 @@ static void cp210x_disable_event_mode(struct usb_serial_port *port)
port_priv->event_mode = false;
}
static bool cp210x_termios_change(const struct ktermios *a, const struct ktermios *b)
{
bool iflag_change;
iflag_change = ((a->c_iflag ^ b->c_iflag) & INPCK);
return tty_termios_hw_change(a, b) || iflag_change;
}
static void cp210x_set_termios(struct tty_struct *tty,
struct usb_serial_port *port, struct ktermios *old_termios)
{
@ -1359,6 +1368,9 @@ static void cp210x_set_termios(struct tty_struct *tty,
unsigned int cflag, old_cflag;
u16 bits;
if (!cp210x_termios_change(&tty->termios, old_termios))
return;
cflag = tty->termios.c_cflag;
old_cflag = old_termios->c_cflag;