nfs: fix error handling in lock_and_join_requests

This fixes handling of errors from nfs_page_group_lock in
nfs_lock_and_join_requests.  It now releases the inode lock and the
reference to the head request.

Reported-by: Peng Tao <tao.peng@primarydata.com>
Signed-off-by: Weston Andros Adamson <dros@primarydata.com>
Reviewed-by: Peng Tao <tao.peng@primarydata.com>
Signed-off-by: Trond Myklebust <trond.myklebust@primarydata.com>
This commit is contained in:
Weston Andros Adamson 2014-08-08 11:00:56 -04:00 committed by Trond Myklebust
parent bfd484a560
commit 94970014c4
1 changed files with 4 additions and 1 deletions

View File

@ -480,8 +480,11 @@ try_again:
/* lock each request in the page group */
ret = nfs_page_group_lock(head, true);
if (ret < 0)
if (ret < 0) {
spin_unlock(&inode->i_lock);
nfs_release_request(head);
return ERR_PTR(ret);
}
subreq = head;
do {
/*