[PATCH] nfsd4_truncate() bogus return value
-EINVAL (in host order, no less) is not a good thing to return to client. nfsd4_truncate() returns it in one case and its callers expect nfs_.... from it. AFAICS, it should be nfserr_inval Signed-off-by: Al Viro <viro@zeniv.linux.org.uk> Signed-off-by: Neil Brown <neilb@suse.de> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
This commit is contained in:
parent
d75f2b9f5d
commit
9246585a11
|
@ -1600,7 +1600,7 @@ nfsd4_truncate(struct svc_rqst *rqstp, struct svc_fh *fh,
|
||||||
if (!open->op_truncate)
|
if (!open->op_truncate)
|
||||||
return 0;
|
return 0;
|
||||||
if (!(open->op_share_access & NFS4_SHARE_ACCESS_WRITE))
|
if (!(open->op_share_access & NFS4_SHARE_ACCESS_WRITE))
|
||||||
return -EINVAL;
|
return nfserr_inval;
|
||||||
return nfsd_setattr(rqstp, fh, &iattr, 0, (time_t)0);
|
return nfsd_setattr(rqstp, fh, &iattr, 0, (time_t)0);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
Loading…
Reference in New Issue