hollalinux
/
linux-sg2042
mirror of https://github.com/sophgo/linux-riscv.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

scsi: target/iscsi: fix possible condition with no effect (if == else) 

Fix the following warning reported by coccicheck:

drivers/target/iscsi/iscsi_target_nego.c:175:6-8: WARNING: possible
condition with no effect (if == else)

Signed-off-by: Hariprasad Kelam <hariprasad.kelam@gmail.com>
Reviewed-by: David Disseldorp <ddiss@suse.de>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
This commit is contained in:
Hariprasad Kelam 2019-05-28 06:51:52 +05:30 committed by Martin K. Petersen
parent 32877947b7
commit 8a914f32e2
1 changed files with 2 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
drivers/target/iscsi/iscsi_target_nego.c
View File

@ -160,22 +160,11 @@ static u32 iscsi_handle_authentication(
if (strstr("None", authtype)) if (strstr("None", authtype))
return 1; return 1;
#ifdef CANSRP
else if (strstr("SRP", authtype))
return srp_main_loop(conn, auth, in_buf, out_buf,
&in_length, out_length);
#endif
else if (strstr("CHAP", authtype)) else if (strstr("CHAP", authtype))
return chap_main_loop(conn, auth, in_buf, out_buf, return chap_main_loop(conn, auth, in_buf, out_buf,
&in_length, out_length); &in_length, out_length);
else if (strstr("SPKM1", authtype)) /* SRP, SPKM1, SPKM2 and KRB5 are unsupported */
return 2; return 2;
else if (strstr("SPKM2", authtype))
return 2;
else if (strstr("KRB5", authtype))
return 2;
else
return 2;
} }
static void iscsi_remove_failed_auth_entry(struct iscsi_conn *conn) static void iscsi_remove_failed_auth_entry(struct iscsi_conn *conn)