nfsd: convert the file_hashtbl to a hlist
We only ever traverse the hash chains in the forward direction, so a double pointer list head isn't really necessary. Signed-off-by: Jeff Layton <jlayton@redhat.com> Signed-off-by: J. Bruce Fields <bfields@redhat.com>
This commit is contained in:
parent
66b2b9b2b0
commit
89876f8c0d
|
@ -236,7 +236,7 @@ static inline void
|
||||||
put_nfs4_file(struct nfs4_file *fi)
|
put_nfs4_file(struct nfs4_file *fi)
|
||||||
{
|
{
|
||||||
if (atomic_dec_and_lock(&fi->fi_ref, &recall_lock)) {
|
if (atomic_dec_and_lock(&fi->fi_ref, &recall_lock)) {
|
||||||
list_del(&fi->fi_hash);
|
hlist_del(&fi->fi_hash);
|
||||||
spin_unlock(&recall_lock);
|
spin_unlock(&recall_lock);
|
||||||
iput(fi->fi_inode);
|
iput(fi->fi_inode);
|
||||||
nfsd4_free_file(fi);
|
nfsd4_free_file(fi);
|
||||||
|
@ -280,7 +280,7 @@ static unsigned int file_hashval(struct inode *ino)
|
||||||
return hash_ptr(ino, FILE_HASH_BITS);
|
return hash_ptr(ino, FILE_HASH_BITS);
|
||||||
}
|
}
|
||||||
|
|
||||||
static struct list_head file_hashtbl[FILE_HASH_SIZE];
|
static struct hlist_head file_hashtbl[FILE_HASH_SIZE];
|
||||||
|
|
||||||
static void __nfs4_file_get_access(struct nfs4_file *fp, int oflag)
|
static void __nfs4_file_get_access(struct nfs4_file *fp, int oflag)
|
||||||
{
|
{
|
||||||
|
@ -2347,7 +2347,6 @@ static void nfsd4_init_file(struct nfs4_file *fp, struct inode *ino)
|
||||||
unsigned int hashval = file_hashval(ino);
|
unsigned int hashval = file_hashval(ino);
|
||||||
|
|
||||||
atomic_set(&fp->fi_ref, 1);
|
atomic_set(&fp->fi_ref, 1);
|
||||||
INIT_LIST_HEAD(&fp->fi_hash);
|
|
||||||
INIT_LIST_HEAD(&fp->fi_stateids);
|
INIT_LIST_HEAD(&fp->fi_stateids);
|
||||||
INIT_LIST_HEAD(&fp->fi_delegations);
|
INIT_LIST_HEAD(&fp->fi_delegations);
|
||||||
fp->fi_inode = igrab(ino);
|
fp->fi_inode = igrab(ino);
|
||||||
|
@ -2356,7 +2355,7 @@ static void nfsd4_init_file(struct nfs4_file *fp, struct inode *ino)
|
||||||
memset(fp->fi_fds, 0, sizeof(fp->fi_fds));
|
memset(fp->fi_fds, 0, sizeof(fp->fi_fds));
|
||||||
memset(fp->fi_access, 0, sizeof(fp->fi_access));
|
memset(fp->fi_access, 0, sizeof(fp->fi_access));
|
||||||
spin_lock(&recall_lock);
|
spin_lock(&recall_lock);
|
||||||
list_add(&fp->fi_hash, &file_hashtbl[hashval]);
|
hlist_add_head(&fp->fi_hash, &file_hashtbl[hashval]);
|
||||||
spin_unlock(&recall_lock);
|
spin_unlock(&recall_lock);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@ -2542,7 +2541,7 @@ find_file(struct inode *ino)
|
||||||
struct nfs4_file *fp;
|
struct nfs4_file *fp;
|
||||||
|
|
||||||
spin_lock(&recall_lock);
|
spin_lock(&recall_lock);
|
||||||
list_for_each_entry(fp, &file_hashtbl[hashval], fi_hash) {
|
hlist_for_each_entry(fp, &file_hashtbl[hashval], fi_hash) {
|
||||||
if (fp->fi_inode == ino) {
|
if (fp->fi_inode == ino) {
|
||||||
get_nfs4_file(fp);
|
get_nfs4_file(fp);
|
||||||
spin_unlock(&recall_lock);
|
spin_unlock(&recall_lock);
|
||||||
|
@ -4810,11 +4809,6 @@ struct nfs4_client *nfsd_find_client(struct sockaddr_storage *addr, size_t addr_
|
||||||
void
|
void
|
||||||
nfs4_state_init(void)
|
nfs4_state_init(void)
|
||||||
{
|
{
|
||||||
int i;
|
|
||||||
|
|
||||||
for (i = 0; i < FILE_HASH_SIZE; i++) {
|
|
||||||
INIT_LIST_HEAD(&file_hashtbl[i]);
|
|
||||||
}
|
|
||||||
INIT_LIST_HEAD(&del_recall_lru);
|
INIT_LIST_HEAD(&del_recall_lru);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
|
@ -380,7 +380,7 @@ static inline struct nfs4_lockowner * lockowner(struct nfs4_stateowner *so)
|
||||||
/* nfs4_file: a file opened by some number of (open) nfs4_stateowners. */
|
/* nfs4_file: a file opened by some number of (open) nfs4_stateowners. */
|
||||||
struct nfs4_file {
|
struct nfs4_file {
|
||||||
atomic_t fi_ref;
|
atomic_t fi_ref;
|
||||||
struct list_head fi_hash; /* hash by "struct inode *" */
|
struct hlist_node fi_hash; /* hash by "struct inode *" */
|
||||||
struct list_head fi_stateids;
|
struct list_head fi_stateids;
|
||||||
struct list_head fi_delegations;
|
struct list_head fi_delegations;
|
||||||
/* One each for O_RDONLY, O_WRONLY, O_RDWR: */
|
/* One each for O_RDONLY, O_WRONLY, O_RDWR: */
|
||||||
|
|
Loading…
Reference in New Issue