hollalinux
/
linux-sg2042
mirror of https://github.com/sophgo/linux-riscv.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[ARM] 4994/1: <IMX UART>: Move error handling into execution path 

Move the error handling code for erroneous receive characters into
execution path. This makes the code more readable and the compiler
should know how to optimize this, right?

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
This commit is contained in:
Sascha Hauer 2008-04-17 08:39:22 +01:00 committed by Russell King
parent 8c9915bf31
commit 864eeed051
1 changed files with 33 additions and 41 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

40
drivers/serial/imx.c
View File

@ -354,40 +354,24 @@ static irqreturn_t imx_rxint(int irq, void *dev_id)
struct tty_struct *tty = sport->port.info->tty; struct tty_struct *tty = sport->port.info->tty;
unsigned long flags, temp; unsigned long flags, temp;
rx = readl(sport->port.membase + URXD0);
spin_lock_irqsave(&sport->port.lock,flags); spin_lock_irqsave(&sport->port.lock,flags);
do { while ((rx = readl(sport->port.membase + URXD0)) & URXD_CHARRDY) {
flg = TTY_NORMAL; flg = TTY_NORMAL;
sport->port.icount.rx++; sport->port.icount.rx++;
temp = readl(sport->port.membase + USR2); temp = readl(sport->port.membase + USR2);
if( temp & USR2_BRCD ) { if (temp & USR2_BRCD) {
writel(temp | USR2_BRCD, sport->port.membase + USR2); writel(temp | USR2_BRCD, sport->port.membase + USR2);
if(uart_handle_break(&sport->port)) if (uart_handle_break(&sport->port))
goto ignore_char; continue;
} }
if (uart_handle_sysrq_char if (uart_handle_sysrq_char
(&sport->port, (unsigned char)rx)) (&sport->port, (unsigned char)rx))
goto ignore_char; continue;
if( rx & (URXD_PRERR | URXD_OVRRUN | URXD_FRMERR) ) if (rx & (URXD_PRERR | URXD_OVRRUN | URXD_FRMERR) ) {
goto handle_error;
error_return:
tty_insert_flip_char(tty, rx, flg);
ignore_char:
rx = readl(sport->port.membase + URXD0);
} while(rx & URXD_CHARRDY);
out:
spin_unlock_irqrestore(&sport->port.lock,flags);
tty_flip_buffer_push(tty);
return IRQ_HANDLED;
handle_error:
if (rx & URXD_PRERR) if (rx & URXD_PRERR)
sport->port.icount.parity++; sport->port.icount.parity++;
else if (rx & URXD_FRMERR) else if (rx & URXD_FRMERR)
@ -398,7 +382,7 @@ handle_error:
if (rx & sport->port.ignore_status_mask) { if (rx & sport->port.ignore_status_mask) {
if (++ignored > 100) if (++ignored > 100)
goto out; goto out;
goto ignore_char; continue;
} }
rx &= sport->port.read_status_mask; rx &= sport->port.read_status_mask;
@ -413,7 +397,15 @@ handle_error:
#ifdef SUPPORT_SYSRQ #ifdef SUPPORT_SYSRQ
sport->port.sysrq = 0; sport->port.sysrq = 0;
#endif #endif
goto error_return; }
tty_insert_flip_char(tty, rx, flg);
}
out:
spin_unlock_irqrestore(&sport->port.lock,flags);
tty_flip_buffer_push(tty);
return IRQ_HANDLED;
} }
/* /*