bcache: Convert to DEFINE_SHOW_ATTRIBUTE
Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code. As inode->iprivate equals to third parameter of debugfs_create_file() which is NULL. So it's equivalent to original code logic. Signed-off-by: Qinglang Miao <miaoqinglang@huawei.com> Signed-off-by: Coly Li <colyli@suse.de> Signed-off-by: Jens Axboe <axboe@kernel.dk>
This commit is contained in:
parent
7e59c506c3
commit
84e5d1363c
|
@ -159,7 +159,7 @@ void closure_debug_destroy(struct closure *cl)
|
||||||
|
|
||||||
static struct dentry *closure_debug;
|
static struct dentry *closure_debug;
|
||||||
|
|
||||||
static int debug_seq_show(struct seq_file *f, void *data)
|
static int debug_show(struct seq_file *f, void *data)
|
||||||
{
|
{
|
||||||
struct closure *cl;
|
struct closure *cl;
|
||||||
|
|
||||||
|
@ -188,17 +188,7 @@ static int debug_seq_show(struct seq_file *f, void *data)
|
||||||
return 0;
|
return 0;
|
||||||
}
|
}
|
||||||
|
|
||||||
static int debug_seq_open(struct inode *inode, struct file *file)
|
DEFINE_SHOW_ATTRIBUTE(debug);
|
||||||
{
|
|
||||||
return single_open(file, debug_seq_show, NULL);
|
|
||||||
}
|
|
||||||
|
|
||||||
static const struct file_operations debug_ops = {
|
|
||||||
.owner = THIS_MODULE,
|
|
||||||
.open = debug_seq_open,
|
|
||||||
.read = seq_read,
|
|
||||||
.release = single_release
|
|
||||||
};
|
|
||||||
|
|
||||||
void __init closure_debug_init(void)
|
void __init closure_debug_init(void)
|
||||||
{
|
{
|
||||||
|
@ -209,7 +199,7 @@ void __init closure_debug_init(void)
|
||||||
* about this.
|
* about this.
|
||||||
*/
|
*/
|
||||||
closure_debug = debugfs_create_file(
|
closure_debug = debugfs_create_file(
|
||||||
"closures", 0400, bcache_debug, NULL, &debug_ops);
|
"closures", 0400, bcache_debug, NULL, &debug_fops);
|
||||||
}
|
}
|
||||||
#endif
|
#endif
|
||||||
|
|
||||||
|
|
Loading…
Reference in New Issue