hollalinux
/
linux-sg2042
mirror of https://github.com/sophgo/linux-riscv.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

firmware: vpd: Destroy vpd sections in remove function 

vpd sections are initialized during probe and thus should be destroyed
in the remove function.

Fixes: 049a59db34 ("firmware: Google VPD sysfs driver")
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Reviewed-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Tested-by: Randy Dunlap <rdunlap@infradead.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Guenter Roeck 2017-11-15 13:00:43 -08:00 committed by Greg Kroah-Hartman
parent 297d6b6e56
commit 811d7e0215
1 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
drivers/firmware/google/vpd.c
View File

@ -298,8 +298,17 @@ static int vpd_probe(struct platform_device *pdev)
return vpd_sections_init(entry.cbmem_addr); return vpd_sections_init(entry.cbmem_addr);
} }
static int vpd_remove(struct platform_device *pdev)
{
vpd_section_destroy(&ro_vpd);
vpd_section_destroy(&rw_vpd);
return 0;
}
static struct platform_driver vpd_driver = { static struct platform_driver vpd_driver = {
.probe = vpd_probe, .probe = vpd_probe,
.remove = vpd_remove,
.driver = { .driver = {
.name = "vpd", .name = "vpd",
}, },
@ -324,8 +333,6 @@ static int __init vpd_platform_init(void)
static void __exit vpd_platform_exit(void) static void __exit vpd_platform_exit(void)
{ {
vpd_section_destroy(&ro_vpd);
vpd_section_destroy(&rw_vpd);
kobject_put(vpd_kobj); kobject_put(vpd_kobj);
} }