hollalinux
/
linux-sg2042
mirror of https://github.com/sophgo/linux-riscv.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[media] au0828: Refactoring for start_urb_transfer() 

This issue was detected by using the Coccinelle software.

1. Let us return directly if a buffer allocation failed.

2. Delete the jump label "err" then.

3. Drop the explicit initialisation for the variable "ret"
   at the beginning.

4. Return zero as a constant at the end.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
This commit is contained in:
Markus Elfring 2015-12-28 19:52:48 -02:00 committed by Mauro Carvalho Chehab
parent 490ba9c29d
commit 80c1bce9aa
1 changed files with 5 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
drivers/media/usb/au0828/au0828-dvb.c
View File

@ -181,7 +181,7 @@ static int stop_urb_transfer(struct au0828_dev *dev)
static int start_urb_transfer(struct au0828_dev *dev) static int start_urb_transfer(struct au0828_dev *dev)
{ {
struct urb *purb; struct urb *purb;
int i, ret = -ENOMEM; int i, ret;
dprintk(2, "%s()\n", __func__); dprintk(2, "%s()\n", __func__);
@ -194,7 +194,7 @@ static int start_urb_transfer(struct au0828_dev *dev)
dev->urbs[i] = usb_alloc_urb(0, GFP_KERNEL); dev->urbs[i] = usb_alloc_urb(0, GFP_KERNEL);
if (!dev->urbs[i]) if (!dev->urbs[i])
goto err; return -ENOMEM;
purb = dev->urbs[i]; purb = dev->urbs[i];
@ -207,9 +207,10 @@ static int start_urb_transfer(struct au0828_dev *dev)
if (!purb->transfer_buffer) { if (!purb->transfer_buffer) {
usb_free_urb(purb); usb_free_urb(purb);
dev->urbs[i] = NULL; dev->urbs[i] = NULL;
ret = -ENOMEM;
pr_err("%s: failed big buffer allocation, err = %d\n", pr_err("%s: failed big buffer allocation, err = %d\n",
__func__, ret); __func__, ret);
goto err; return ret;
} }
purb->status = -EINPROGRESS; purb->status = -EINPROGRESS;
@ -235,10 +236,7 @@ static int start_urb_transfer(struct au0828_dev *dev)
} }
dev->urb_streaming = true; dev->urb_streaming = true;
ret = 0; return 0;
err:
return ret;
} }
static void au0828_start_transport(struct au0828_dev *dev) static void au0828_start_transport(struct au0828_dev *dev)