misc: pci_endpoint_test: Fix failure path return values in probe
Return value of pci_endpoint_test_probe is not set properly in a couple of failure cases. Fix it here. Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
This commit is contained in:
parent
a2db2663bd
commit
80068c9368
|
@ -542,6 +542,7 @@ static int pci_endpoint_test_probe(struct pci_dev *pdev,
|
||||||
|
|
||||||
test->base = test->bar[test_reg_bar];
|
test->base = test->bar[test_reg_bar];
|
||||||
if (!test->base) {
|
if (!test->base) {
|
||||||
|
err = -ENOMEM;
|
||||||
dev_err(dev, "Cannot perform PCI test without BAR%d\n",
|
dev_err(dev, "Cannot perform PCI test without BAR%d\n",
|
||||||
test_reg_bar);
|
test_reg_bar);
|
||||||
goto err_iounmap;
|
goto err_iounmap;
|
||||||
|
@ -551,6 +552,7 @@ static int pci_endpoint_test_probe(struct pci_dev *pdev,
|
||||||
|
|
||||||
id = ida_simple_get(&pci_endpoint_test_ida, 0, 0, GFP_KERNEL);
|
id = ida_simple_get(&pci_endpoint_test_ida, 0, 0, GFP_KERNEL);
|
||||||
if (id < 0) {
|
if (id < 0) {
|
||||||
|
err = id;
|
||||||
dev_err(dev, "unable to get id\n");
|
dev_err(dev, "unable to get id\n");
|
||||||
goto err_iounmap;
|
goto err_iounmap;
|
||||||
}
|
}
|
||||||
|
|
Loading…
Reference in New Issue