hollalinux
/
linux-sg2042
mirror of https://github.com/sophgo/linux-riscv.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

staging: comedi: jr3_pci: check sizes at compile time 

The driver currently checks the size of `struct jr3_sensor` is correct
when a device is attached, returning an error if it is wrong.  Replace
that with a compile-time check.  We don't care too much about the size
of `struct jr3_sensor` as it is embedded in the larger `struct
jr3_block` and is followed by a lot of padding.  We should care more
that the size of `struct jr3_block` is correct, as it describes the
overall register layout of a block, and there is an array of such blocks
(one per subdevice).  Check its size at compile-time using the
`BUILD_BUG_ON()` macro.

Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Ian Abbott 2017-03-08 18:44:30 +00:00 committed by Greg Kroah-Hartman
parent 6fbd1330e5
commit 7cb1c5c2cd
1 changed files with 1 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
drivers/staging/comedi/drivers/jr3_pci.c
View File

@ -688,12 +688,7 @@ static int jr3_pci_auto_attach(struct comedi_device *dev,
int ret;
int i;
if (sizeof(struct jr3_sensor) != 0xc00) {
dev_err(dev->class_dev,
"sizeof(struct jr3_sensor) = %x [expected %x]\n",
(unsigned int)sizeof(struct jr3_sensor), 0xc00);
return -EINVAL;
}
BUILD_BUG_ON(sizeof(struct jr3_block) != 0x80000);
if (context < ARRAY_SIZE(jr3_pci_boards))
board = &jr3_pci_boards[context];