hollalinux
/
linux-sg2042
mirror of https://github.com/sophgo/linux-riscv.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

enic: Use offsetof macro in vic tlv length calculation 

Signed-off-by: Scott Feldman <scofeldm@cisco.com>
Signed-off-by: Roopa Prabhu <roprabhu@cisco.com>
Signed-off-by: Vasanthy Kolluri <vkolluri@cisco.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Roopa Prabhu 2010-08-10 18:55:10 +00:00 committed by David S. Miller
parent ae94abe168
commit 7c46835e48
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
drivers/net/enic/vnic_vic.c
View File

@ -54,8 +54,8 @@ int vic_provinfo_add_tlv(struct vic_provinfo *vp, u16 type, u16 length,
if (!vp || !value) if (!vp || !value)
return -EINVAL; return -EINVAL;
if (ntohl(vp->length) + sizeof(*tlv) + length > if (ntohl(vp->length) + offsetof(struct vic_provinfo_tlv, value) +
VIC_PROVINFO_MAX_TLV_DATA) length > VIC_PROVINFO_MAX_TLV_DATA)
return -ENOMEM; return -ENOMEM;
tlv = (struct vic_provinfo_tlv *)((u8 *)vp->tlv + tlv = (struct vic_provinfo_tlv *)((u8 *)vp->tlv +
@ -66,7 +66,8 @@ int vic_provinfo_add_tlv(struct vic_provinfo *vp, u16 type, u16 length,
memcpy(tlv->value, value, length); memcpy(tlv->value, value, length);
vp->num_tlvs = htonl(ntohl(vp->num_tlvs) + 1); vp->num_tlvs = htonl(ntohl(vp->num_tlvs) + 1);
vp->length = htonl(ntohl(vp->length) + sizeof(*tlv) + length); vp->length = htonl(ntohl(vp->length) +
offsetof(struct vic_provinfo_tlv, value) + length);
return 0; return 0;
} }