e1000: convert to use netdev_for_each_mc_addr

Signed-off-by: Jiri Pirko <jpirko@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Jiri Pirko 2010-02-22 09:10:44 +00:00 committed by David S. Miller
parent 0ddf477b8a
commit 7a81e9f3ca
1 changed files with 17 additions and 20 deletions

View File

@ -2161,23 +2161,9 @@ static void e1000_set_rx_mode(struct net_device *netdev)
WARN_ON(i == rar_entries); WARN_ON(i == rar_entries);
mc_ptr = netdev->mc_list; netdev_for_each_mc_addr(mc_ptr, netdev) {
if (i == rar_entries) {
for (; i < rar_entries; i++) {
if (mc_ptr) {
e1000_rar_set(hw, mc_ptr->da_addr, i);
mc_ptr = mc_ptr->next;
} else {
E1000_WRITE_REG_ARRAY(hw, RA, i << 1, 0);
E1000_WRITE_FLUSH();
E1000_WRITE_REG_ARRAY(hw, RA, (i << 1) + 1, 0);
E1000_WRITE_FLUSH();
}
}
/* load any remaining addresses into the hash table */ /* load any remaining addresses into the hash table */
for (; mc_ptr; mc_ptr = mc_ptr->next) {
u32 hash_reg, hash_bit, mta; u32 hash_reg, hash_bit, mta;
hash_value = e1000_hash_mc_addr(hw, mc_ptr->da_addr); hash_value = e1000_hash_mc_addr(hw, mc_ptr->da_addr);
hash_reg = (hash_value >> 5) & 0x7F; hash_reg = (hash_value >> 5) & 0x7F;
@ -2185,6 +2171,17 @@ static void e1000_set_rx_mode(struct net_device *netdev)
mta = (1 << hash_bit); mta = (1 << hash_bit);
mcarray[hash_reg] |= mta; mcarray[hash_reg] |= mta;
} }
else {
e1000_rar_set(hw, mc_ptr->da_addr, i++);
}
}
for (; i < rar_entries; i++) {
E1000_WRITE_REG_ARRAY(hw, RA, i << 1, 0);
E1000_WRITE_FLUSH();
E1000_WRITE_REG_ARRAY(hw, RA, (i << 1) + 1, 0);
E1000_WRITE_FLUSH();
}
/* write the hash table completely, write from bottom to avoid /* write the hash table completely, write from bottom to avoid
* both stupid write combining chipsets, and flushing each write */ * both stupid write combining chipsets, and flushing each write */