Correctly close old nfsd/lockd sockets.
Commit aaf68cfbf2
added a bias
to sk_inuse, so this test for an unused socket now fails. So no
sockets get closed because they are old (they might get closed
if the client closed them).
This bug has existed since 2.6.21-rc1.
Thanks to Wolfgang Walter for finding and reporting the bug.
Cc: Wolfgang Walter <wolfgang.walter@studentenwerk.mhn.de>
Signed-off-by: Neil Brown <neilb@suse.de>
Signed-off-by: J. Bruce Fields <bfields@citi.umich.edu>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
parent
2123a09f3f
commit
7a1fa065a0
|
@ -1592,7 +1592,7 @@ svc_age_temp_sockets(unsigned long closure)
|
|||
|
||||
if (!test_and_set_bit(SK_OLD, &svsk->sk_flags))
|
||||
continue;
|
||||
if (atomic_read(&svsk->sk_inuse) || test_bit(SK_BUSY, &svsk->sk_flags))
|
||||
if (atomic_read(&svsk->sk_inuse) > 1 || test_bit(SK_BUSY, &svsk->sk_flags))
|
||||
continue;
|
||||
atomic_inc(&svsk->sk_inuse);
|
||||
list_move(le, &to_be_aged);
|
||||
|
|
Loading…
Reference in New Issue