hollalinux
/
linux-sg2042
mirror of https://github.com/sophgo/linux-riscv.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

ubifs: Fix memory leak in __ubifs_node_verify_hmac error path 

In __ubifs_node_verify_hmac(), 'hmac' is allocated through kmalloc().
However, it is not deallocated in the following execution if
ubifs_node_calc_hmac() fails, leading to a memory leak bug. To fix this
issue, free 'hmac' before returning the error.

Fixes: 49525e5eec ("ubifs: Add helper functions for authentication support")
Signed-off-by: Wenwen Wang <wenwen@cs.uga.edu>
Signed-off-by: Richard Weinberger <richard@nod.at>
This commit is contained in:
Wenwen Wang 2019-08-19 22:24:50 -05:00 committed by Richard Weinberger
parent ce4d8b16e6
commit 7992e00469
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
fs/ubifs/auth.c
View File

@ -479,8 +479,10 @@ int __ubifs_node_verify_hmac(const struct ubifs_info *c, const void *node,
return -ENOMEM; return -ENOMEM;
err = ubifs_node_calc_hmac(c, node, len, ofs_hmac, hmac); err = ubifs_node_calc_hmac(c, node, len, ofs_hmac, hmac);
if (err) if (err) {
kfree(hmac);
return err; return err;
}
err = crypto_memneq(hmac, node + ofs_hmac, hmac_len); err = crypto_memneq(hmac, node + ofs_hmac, hmac_len);