hollalinux
/
linux-sg2042
mirror of https://github.com/sophgo/linux-riscv.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

isdnloop: Validate NUL-terminated strings from user. 

Return -EINVAL unless all of user-given strings are correctly
NUL-terminated.

Signed-off-by: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
YOSHIFUJI Hideaki / 吉藤英明 2014-04-02 12:48:42 +09:00 committed by David S. Miller
parent 79eb9d28c9
commit 77bc6bed71
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/isdn/isdnloop/isdnloop.c
View File

@ -1070,6 +1070,12 @@ isdnloop_start(isdnloop_card *card, isdnloop_sdef *sdefp)
return -EBUSY; return -EBUSY;
if (copy_from_user((char *) &sdef, (char *) sdefp, sizeof(sdef))) if (copy_from_user((char *) &sdef, (char *) sdefp, sizeof(sdef)))
return -EFAULT; return -EFAULT;
for (i = 0; i < 3; i++) {
if (!memchr(sdef.num[i], 0, sizeof(sdef.num[i])))
return -EINVAL;
}
spin_lock_irqsave(&card->isdnloop_lock, flags); spin_lock_irqsave(&card->isdnloop_lock, flags);
switch (sdef.ptype) { switch (sdef.ptype) {
case ISDN_PTYPE_EURO: case ISDN_PTYPE_EURO: