hollalinux
/
linux-sg2042
mirror of https://github.com/sophgo/linux-riscv.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

bus: mvebu-mbus: potential forever loop in mvebu_mbus_init() 

"of_id->compatible" is an array and not a pointer so it can never be
NULL.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
Signed-off-by: Jason Cooper <jason@lakedaemon.net>
This commit is contained in:
Dan Carpenter 2013-11-13 10:50:24 +03:00 committed by Jason Cooper
parent 6ce4eac1f6
commit 7663cfd3f4
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/bus/mvebu-mbus.c
View File

@ -734,11 +734,11 @@ int __init mvebu_mbus_init(const char *soc, phys_addr_t mbuswins_phys_base,
{ {
const struct of_device_id *of_id; const struct of_device_id *of_id;
for (of_id = of_mvebu_mbus_ids; of_id->compatible; of_id++) for (of_id = of_mvebu_mbus_ids; of_id->compatible[0]; of_id++)
if (!strcmp(of_id->compatible, soc)) if (!strcmp(of_id->compatible, soc))
break; break;
if (!of_id->compatible) { if (!of_id->compatible[0]) {
pr_err("could not find a matching SoC family\n"); pr_err("could not find a matching SoC family\n");
return -ENODEV; return -ENODEV;
} }