lib/vsprintf.c: also improve sanity check in bstr_printf()
Quoting from 2aa2f9e21e
("lib/vsprintf.c: improve sanity check in
vsnprintf()"):
On 64 bit, size may very well be huge even if bit 31 happens to be 0.
Somehow it doesn't feel right that one can pass a 5 GiB buffer but not a
3 GiB one. So cap at INT_MAX as was probably the intention all along.
This is also the made-up value passed by sprintf and vsprintf.
I should have seen this copy-pasted instance back then, but let's just
do it now.
Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: Kees Cook <keescook@chromium.org>
Cc: Martin Kletzander <mkletzan@redhat.com>
Cc: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
parent
b006f19b05
commit
762abb5154
|
@ -2270,7 +2270,7 @@ int bstr_printf(char *buf, size_t size, const char *fmt, const u32 *bin_buf)
|
|||
char *str, *end;
|
||||
const char *args = (const char *)bin_buf;
|
||||
|
||||
if (WARN_ON_ONCE((int) size < 0))
|
||||
if (WARN_ON_ONCE(size > INT_MAX))
|
||||
return 0;
|
||||
|
||||
str = buf;
|
||||
|
|
Loading…
Reference in New Issue