hollalinux
/
linux-sg2042
mirror of https://github.com/sophgo/linux-riscv.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

kmemleak: Report previously found leaks even after an error 

If an error fatal to kmemleak (like memory allocation failure) happens,
kmemleak disables itself but it also removes the access to any
previously found memory leaks. This patch allows read-only access to the
kmemleak debugfs interface but disables any other action.

Reported-by: Nick Bowler <nbowler@elliptictech.com>
Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
This commit is contained in:
Catalin Marinas 2011-09-29 11:50:07 +01:00
parent b66930052a
commit 74341703ed
1 changed files with 13 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
mm/kmemleak.c
View File

@ -1473,9 +1473,6 @@ static const struct seq_operations kmemleak_seq_ops = {
static int kmemleak_open(struct inode *inode, struct file *file) static int kmemleak_open(struct inode *inode, struct file *file)
{ {
if (!atomic_read(&kmemleak_enabled))
return -EBUSY;
return seq_open(file, &kmemleak_seq_ops); return seq_open(file, &kmemleak_seq_ops);
} }
@ -1549,6 +1546,9 @@ static ssize_t kmemleak_write(struct file *file, const char __user *user_buf,
int buf_size; int buf_size;
int ret; int ret;
if (!atomic_read(&kmemleak_enabled))
return -EBUSY;
buf_size = min(size, (sizeof(buf) - 1)); buf_size = min(size, (sizeof(buf) - 1));
if (strncpy_from_user(buf, user_buf, buf_size) < 0) if (strncpy_from_user(buf, user_buf, buf_size) < 0)
return -EFAULT; return -EFAULT;
@ -1608,20 +1608,24 @@ static const struct file_operations kmemleak_fops = {
}; };
/* /*
* Perform the freeing of the kmemleak internal objects after waiting for any * Stop the memory scanning thread and free the kmemleak internal objects if
* current memory scan to complete. * no previous scan thread (otherwise, kmemleak may still have some useful
* information on memory leaks).
*/ */
static void kmemleak_do_cleanup(struct work_struct *work) static void kmemleak_do_cleanup(struct work_struct *work)
{ {
struct kmemleak_object *object; struct kmemleak_object *object;
bool cleanup = scan_thread == NULL;
mutex_lock(&scan_mutex); mutex_lock(&scan_mutex);
stop_scan_thread(); stop_scan_thread();
rcu_read_lock(); if (cleanup) {
list_for_each_entry_rcu(object, &object_list, object_list) rcu_read_lock();
delete_object_full(object->pointer); list_for_each_entry_rcu(object, &object_list, object_list)
rcu_read_unlock(); delete_object_full(object->pointer);
rcu_read_unlock();
}
mutex_unlock(&scan_mutex); mutex_unlock(&scan_mutex);
} }