sched/numa: Override part of migrate_degrades_locality() when idle balancing
Several tests in the NAS benchmark seem to run a lot slower with NUMA balancing enabled, than with NUMA balancing disabled. The slower run time corresponds with increased idle time. Overriding the final test of migrate_degrades_locality (but still doing the other NUMA tests first) seems to improve performance of those benchmarks. Reported-by: Jirka Hladky <jhladky@redhat.com> Signed-off-by: Rik van Riel <riel@redhat.com> Cc: Linus Torvalds <torvalds@linux-foundation.org> Cc: Mel Gorman <mgorman@suse.de> Cc: Mike Galbraith <efault@gmx.de> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: linux-kernel@vger.kernel.org Link: http://lkml.kernel.org/r/20170623165530.22514-2-riel@redhat.com Signed-off-by: Ingo Molnar <mingo@kernel.org>
This commit is contained in:
parent
1bc3cd4dfa
commit
739294fb03
|
@ -6688,6 +6688,10 @@ static int migrate_degrades_locality(struct task_struct *p, struct lb_env *env)
|
||||||
if (dst_nid == p->numa_preferred_nid)
|
if (dst_nid == p->numa_preferred_nid)
|
||||||
return 0;
|
return 0;
|
||||||
|
|
||||||
|
/* Leaving a core idle is often worse than degrading locality. */
|
||||||
|
if (env->idle != CPU_NOT_IDLE)
|
||||||
|
return -1;
|
||||||
|
|
||||||
if (numa_group) {
|
if (numa_group) {
|
||||||
src_faults = group_faults(p, src_nid);
|
src_faults = group_faults(p, src_nid);
|
||||||
dst_faults = group_faults(p, dst_nid);
|
dst_faults = group_faults(p, dst_nid);
|
||||||
|
|
Loading…
Reference in New Issue