[PATCH] dcookies.c: use proper refcounting functions
Dcookies shouldn't play with the internals of dentry and vfsmnt refcounting. It defeats grepping, and is prone to break if implementation details change. In addition the function doesn't even seem to be performance critical: it calls kmem_cache_alloc(). Signed-off-by: Miklos Szeredi <miklos@szeredi.hu> Acked-by: Christoph Hellwig <hch@lst.de> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
This commit is contained in:
parent
484e389c63
commit
732dbef606
|
@ -94,12 +94,10 @@ static struct dcookie_struct * alloc_dcookie(struct dentry * dentry,
|
|||
if (!dcs)
|
||||
return NULL;
|
||||
|
||||
atomic_inc(&dentry->d_count);
|
||||
atomic_inc(&vfsmnt->mnt_count);
|
||||
dentry->d_cookie = dcs;
|
||||
|
||||
dcs->dentry = dentry;
|
||||
dcs->vfsmnt = vfsmnt;
|
||||
dcs->dentry = dget(dentry);
|
||||
dcs->vfsmnt = mntget(vfsmnt);
|
||||
hash_dcookie(dcs);
|
||||
|
||||
return dcs;
|
||||
|
|
Loading…
Reference in New Issue