hollalinux
/
linux-sg2042
mirror of https://github.com/sophgo/linux-riscv.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

media: em28xx-input: improve error handling code 

The current I2C error handling logic makes static analyzers
confused:

	drivers/media/usb/em28xx/em28xx-input.c:96 em28xx_get_key_terratec() error: uninitialized symbol 'b'.

Change it to match the coding style we're using elsewhere.

Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
This commit is contained in:
Mauro Carvalho Chehab 2018-03-23 07:33:22 -04:00
parent 2be09d8d83
commit 728d9fd9f1
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
drivers/media/usb/em28xx/em28xx-input.c
View File

@ -82,11 +82,16 @@ struct em28xx_IR {
static int em28xx_get_key_terratec(struct i2c_client *i2c_dev,
enum rc_proto *protocol, u32 *scancode)
{
int rc;
unsigned char b;
/* poll IR chip */
if (i2c_master_recv(i2c_dev, &b, 1) != 1)
rc = i2c_master_recv(i2c_dev, &b, 1);
if (rc != 1) {
if (rc < 0)
return rc;
return -EIO;
}
/*
* it seems that 0xFE indicates that a button is still hold