hollalinux
/
linux-sg2042
mirror of https://github.com/sophgo/linux-riscv.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[media] media: rc: only turn on LED if keypress generated 

Since v3.12, specifically 153a60bb0f ([media] rc: add feedback led
trigger for rc keypresses), an LED trigger is activated on IR keydown
whether or not a keypress is generated (i.e. even if there's no matching
keycode). However the repeat and keyup logic isn't used unless there is
a keypress, which results in non-keypress keydown events turning on the
LED and not turning it off again.

On the assumption that the intent was for the LED only to light up on
valid key presses (you probably don't want it lighting up for the wrong
remote control for example), move the led_trigger_event() call inside
the keycode check.

Signed-off-by: James Hogan <james.hogan@imgtec.com>
Acked-by: Sean Young <sean@mess.org>
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
This commit is contained in:
James Hogan 2014-01-16 19:56:22 -03:00 committed by Mauro Carvalho Chehab
parent def6221604
commit 70a2f9120f
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/media/rc/rc-main.c
View File

@ -653,9 +653,10 @@ static void ir_do_keydown(struct rc_dev *dev, int scancode,
"key 0x%04x, scancode 0x%04x\n", "key 0x%04x, scancode 0x%04x\n",
dev->input_name, keycode, scancode); dev->input_name, keycode, scancode);
input_report_key(dev->input_dev, keycode, 1); input_report_key(dev->input_dev, keycode, 1);
led_trigger_event(led_feedback, LED_FULL);
} }
led_trigger_event(led_feedback, LED_FULL);
input_sync(dev->input_dev); input_sync(dev->input_dev);
} }