hollalinux
/
linux-sg2042
mirror of https://github.com/sophgo/linux-riscv.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[ALSA] au88x0: mem leak fix in snd_vortex_create() 

In sound/pci/au88x0/au88x0.c::snd_vortex_create() :
The Coverity checker found that if we allocate storage for 'chip'
but then leave via the  regions_out:  label, then we end up leaking
the storage allocated for 'chip'.
I believe simply freeing 'chip' before the 'return err;' line is
all we need to fix this, but please double-check me :)

Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Jaroslav Kysela <perex@suse.cz>
This commit is contained in:
Jesper Juhl 2007-08-06 14:05:27 +02:00 committed by Jaroslav Kysela
parent 12f288bffe
commit 6ed44ad3eb
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
sound/pci/au88x0/au88x0.c
View File

@ -232,6 +232,7 @@ snd_vortex_create(struct snd_card *card, struct pci_dev *pci, vortex_t ** rchip)
pci_disable_device(chip->pci_dev); pci_disable_device(chip->pci_dev);
//FIXME: this not the right place to unregister the gameport //FIXME: this not the right place to unregister the gameport
vortex_gameport_unregister(chip); vortex_gameport_unregister(chip);
kfree(chip);
return err; return err;
} }