hollalinux
/
linux-sg2042
mirror of https://github.com/sophgo/linux-riscv.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[media] rtl28xxu: do not refcount rtl2832_sdr module 

This driver, rtl28xxu, offers frontend service for rtl2832_sdr
module, thus we are producer and rtl2832_sdr module is consumer.
Due to that, reference counting should be done in way rtl2832_sdr
takes refrence to rtl28xxu. Remove wrong refcount.

Signed-off-by: Antti Palosaari <crope@iki.fi>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
This commit is contained in:
Antti Palosaari 2014-12-17 08:16:10 -03:00 committed by Mauro Carvalho Chehab
parent a6f62431a0
commit 6a53fa2350
1 changed files with 2 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
drivers/media/usb/dvb-usb-v2/rtl28xxu.c
View File

@ -1142,16 +1142,12 @@ static int rtl2832u_tuner_attach(struct dvb_usb_adapter *adap)
pdata.v4l2_subdev = subdev; pdata.v4l2_subdev = subdev;
request_module("%s", "rtl2832_sdr"); request_module("%s", "rtl2832_sdr");
pdev = platform_device_register_data(&priv->i2c_client_demod->dev, pdev = platform_device_register_data(&d->intf->dev,
"rtl2832_sdr", "rtl2832_sdr",
PLATFORM_DEVID_AUTO, PLATFORM_DEVID_AUTO,
&pdata, sizeof(pdata)); &pdata, sizeof(pdata));
if (pdev == NULL || pdev->dev.driver == NULL) if (pdev == NULL || pdev->dev.driver == NULL)
break; break;
if (!try_module_get(pdev->dev.driver->owner)) {
platform_device_unregister(pdev);
break;
}
priv->platform_device_sdr = pdev; priv->platform_device_sdr = pdev;
break; break;
default: default:
@ -1175,10 +1171,8 @@ static int rtl2832u_tuner_detach(struct dvb_usb_adapter *adap)
/* remove platform SDR */ /* remove platform SDR */
pdev = priv->platform_device_sdr; pdev = priv->platform_device_sdr;
if (pdev) { if (pdev)
module_put(pdev->dev.driver->owner);
platform_device_unregister(pdev); platform_device_unregister(pdev);
}
/* remove I2C tuner */ /* remove I2C tuner */
client = priv->i2c_client_tuner; client = priv->i2c_client_tuner;