ACPICA: Move all ASCII utilities to a common file
ACPICA commit ba60e4500053010bf775d58f6f61febbdb94d817 New file is utascii.c Link: https://github.com/acpica/acpica/commit/ba60e450 Signed-off-by: Bob Moore <robert.moore@intel.com> Signed-off-by: Lv Zheng <lv.zheng@intel.com> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
This commit is contained in:
parent
66b1ed5aa8
commit
6a0df32c22
|
@ -150,6 +150,7 @@ acpi-y += \
|
|||
acpi-y += \
|
||||
utaddress.o \
|
||||
utalloc.o \
|
||||
utascii.o \
|
||||
utbuffer.o \
|
||||
utcopy.o \
|
||||
utexcep.o \
|
||||
|
|
|
@ -161,8 +161,6 @@ acpi_tb_install_fixed_table(acpi_physical_address address,
|
|||
|
||||
acpi_status acpi_tb_parse_root_table(acpi_physical_address rsdp_address);
|
||||
|
||||
u8 acpi_is_valid_signature(char *signature);
|
||||
|
||||
/*
|
||||
* tbxfload
|
||||
*/
|
||||
|
|
|
@ -166,6 +166,15 @@ struct acpi_pkg_info {
|
|||
#define DB_DWORD_DISPLAY 4
|
||||
#define DB_QWORD_DISPLAY 8
|
||||
|
||||
/*
|
||||
* utascii - ASCII utilities
|
||||
*/
|
||||
u8 acpi_ut_valid_nameseg(char *signature);
|
||||
|
||||
u8 acpi_ut_valid_name_char(char character, u32 position);
|
||||
|
||||
void acpi_ut_check_and_repair_ascii(u8 *name, char *repaired_name, u32 count);
|
||||
|
||||
/*
|
||||
* utnonansi - Non-ANSI C library functions
|
||||
*/
|
||||
|
@ -579,10 +588,6 @@ void acpi_ut_print_string(char *string, u16 max_length);
|
|||
void ut_convert_backslashes(char *pathname);
|
||||
#endif
|
||||
|
||||
u8 acpi_ut_valid_acpi_name(char *name);
|
||||
|
||||
u8 acpi_ut_valid_acpi_char(char character, u32 position);
|
||||
|
||||
void acpi_ut_repair_name(char *name);
|
||||
|
||||
#if defined (ACPI_DEBUGGER) || defined (ACPI_APPLICATION)
|
||||
|
|
|
@ -709,7 +709,7 @@ acpi_db_integrity_walk(acpi_handle obj_handle,
|
|||
return (AE_OK);
|
||||
}
|
||||
|
||||
if (!acpi_ut_valid_acpi_name(node->name.ascii)) {
|
||||
if (!acpi_ut_valid_nameseg(node->name.ascii)) {
|
||||
acpi_os_printf("Invalid AcpiName for Node %p\n", node);
|
||||
return (AE_OK);
|
||||
}
|
||||
|
|
|
@ -178,7 +178,7 @@ static acpi_status acpi_ex_name_segment(u8 ** in_aml_address, char *name_string)
|
|||
|
||||
for (index = 0;
|
||||
(index < ACPI_NAME_SIZE)
|
||||
&& (acpi_ut_valid_acpi_char(*aml_address, 0)); index++) {
|
||||
&& (acpi_ut_valid_name_char(*aml_address, 0)); index++) {
|
||||
char_buf[index] = *aml_address++;
|
||||
ACPI_DEBUG_PRINT((ACPI_DB_LOAD, "%c\n", char_buf[index]));
|
||||
}
|
||||
|
|
|
@ -401,9 +401,9 @@ acpi_tb_verify_temp_table(struct acpi_table_desc *table_desc, char *signature)
|
|||
ACPI_EXCEPTION((AE_INFO, AE_NO_MEMORY,
|
||||
"%4.4s 0x%8.8X%8.8X"
|
||||
" Attempted table install failed",
|
||||
acpi_ut_valid_acpi_name(table_desc->
|
||||
signature.
|
||||
ascii) ?
|
||||
acpi_ut_valid_nameseg(table_desc->
|
||||
signature.
|
||||
ascii) ?
|
||||
table_desc->signature.ascii : "????",
|
||||
ACPI_FORMAT_UINT64(table_desc->
|
||||
address)));
|
||||
|
|
|
@ -76,7 +76,7 @@ acpi_tb_find_table(char *signature,
|
|||
|
||||
/* Validate the input table signature */
|
||||
|
||||
if (!acpi_is_valid_signature(signature)) {
|
||||
if (!acpi_ut_valid_nameseg(signature)) {
|
||||
return_ACPI_STATUS(AE_BAD_SIGNATURE);
|
||||
}
|
||||
|
||||
|
|
|
@ -299,9 +299,9 @@ acpi_tb_install_standard_table(acpi_physical_address address,
|
|||
ACPI_BIOS_ERROR((AE_INFO,
|
||||
"Table has invalid signature [%4.4s] (0x%8.8X), "
|
||||
"must be SSDT or OEMx",
|
||||
acpi_ut_valid_acpi_name(new_table_desc.
|
||||
signature.
|
||||
ascii) ?
|
||||
acpi_ut_valid_nameseg(new_table_desc.
|
||||
signature.
|
||||
ascii) ?
|
||||
new_table_desc.signature.
|
||||
ascii : "????",
|
||||
new_table_desc.signature.integer));
|
||||
|
|
|
@ -380,30 +380,3 @@ next_table:
|
|||
acpi_os_unmap_memory(table, length);
|
||||
return_ACPI_STATUS(AE_OK);
|
||||
}
|
||||
|
||||
/*******************************************************************************
|
||||
*
|
||||
* FUNCTION: acpi_is_valid_signature
|
||||
*
|
||||
* PARAMETERS: signature - Sig string to be validated
|
||||
*
|
||||
* RETURN: TRUE if signature is has 4 valid ACPI characters
|
||||
*
|
||||
* DESCRIPTION: Validate an ACPI table signature.
|
||||
*
|
||||
******************************************************************************/
|
||||
|
||||
u8 acpi_is_valid_signature(char *signature)
|
||||
{
|
||||
u32 i;
|
||||
|
||||
/* Validate each character in the signature */
|
||||
|
||||
for (i = 0; i < ACPI_NAME_SIZE; i++) {
|
||||
if (!acpi_ut_valid_acpi_char(signature[i], i)) {
|
||||
return (FALSE);
|
||||
}
|
||||
}
|
||||
|
||||
return (TRUE);
|
||||
}
|
||||
|
|
|
@ -0,0 +1,140 @@
|
|||
/******************************************************************************
|
||||
*
|
||||
* Module Name: utascii - Utility ascii functions
|
||||
*
|
||||
*****************************************************************************/
|
||||
|
||||
/*
|
||||
* Copyright (C) 2000 - 2016, Intel Corp.
|
||||
* All rights reserved.
|
||||
*
|
||||
* Redistribution and use in source and binary forms, with or without
|
||||
* modification, are permitted provided that the following conditions
|
||||
* are met:
|
||||
* 1. Redistributions of source code must retain the above copyright
|
||||
* notice, this list of conditions, and the following disclaimer,
|
||||
* without modification.
|
||||
* 2. Redistributions in binary form must reproduce at minimum a disclaimer
|
||||
* substantially similar to the "NO WARRANTY" disclaimer below
|
||||
* ("Disclaimer") and any redistribution must be conditioned upon
|
||||
* including a substantially similar Disclaimer requirement for further
|
||||
* binary redistribution.
|
||||
* 3. Neither the names of the above-listed copyright holders nor the names
|
||||
* of any contributors may be used to endorse or promote products derived
|
||||
* from this software without specific prior written permission.
|
||||
*
|
||||
* Alternatively, this software may be distributed under the terms of the
|
||||
* GNU General Public License ("GPL") version 2 as published by the Free
|
||||
* Software Foundation.
|
||||
*
|
||||
* NO WARRANTY
|
||||
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
|
||||
* "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
|
||||
* LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTIBILITY AND FITNESS FOR
|
||||
* A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
|
||||
* HOLDERS OR CONTRIBUTORS BE LIABLE FOR SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
|
||||
* DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
|
||||
* OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
|
||||
* HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT,
|
||||
* STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING
|
||||
* IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
|
||||
* POSSIBILITY OF SUCH DAMAGES.
|
||||
*/
|
||||
|
||||
#include <acpi/acpi.h>
|
||||
#include "accommon.h"
|
||||
|
||||
/*******************************************************************************
|
||||
*
|
||||
* FUNCTION: acpi_ut_valid_nameseg
|
||||
*
|
||||
* PARAMETERS: name - The name or table signature to be examined.
|
||||
* Four characters, does not have to be a
|
||||
* NULL terminated string.
|
||||
*
|
||||
* RETURN: TRUE if signature is has 4 valid ACPI characters
|
||||
*
|
||||
* DESCRIPTION: Validate an ACPI table signature.
|
||||
*
|
||||
******************************************************************************/
|
||||
|
||||
u8 acpi_ut_valid_nameseg(char *name)
|
||||
{
|
||||
u32 i;
|
||||
|
||||
/* Validate each character in the signature */
|
||||
|
||||
for (i = 0; i < ACPI_NAME_SIZE; i++) {
|
||||
if (!acpi_ut_valid_name_char(name[i], i)) {
|
||||
return (FALSE);
|
||||
}
|
||||
}
|
||||
|
||||
return (TRUE);
|
||||
}
|
||||
|
||||
/*******************************************************************************
|
||||
*
|
||||
* FUNCTION: acpi_ut_valid_name_char
|
||||
*
|
||||
* PARAMETERS: char - The character to be examined
|
||||
* position - Byte position (0-3)
|
||||
*
|
||||
* RETURN: TRUE if the character is valid, FALSE otherwise
|
||||
*
|
||||
* DESCRIPTION: Check for a valid ACPI character. Must be one of:
|
||||
* 1) Upper case alpha
|
||||
* 2) numeric
|
||||
* 3) underscore
|
||||
*
|
||||
* We allow a '!' as the last character because of the ASF! table
|
||||
*
|
||||
******************************************************************************/
|
||||
|
||||
u8 acpi_ut_valid_name_char(char character, u32 position)
|
||||
{
|
||||
|
||||
if (!((character >= 'A' && character <= 'Z') ||
|
||||
(character >= '0' && character <= '9') || (character == '_'))) {
|
||||
|
||||
/* Allow a '!' in the last position */
|
||||
|
||||
if (character == '!' && position == 3) {
|
||||
return (TRUE);
|
||||
}
|
||||
|
||||
return (FALSE);
|
||||
}
|
||||
|
||||
return (TRUE);
|
||||
}
|
||||
|
||||
/*******************************************************************************
|
||||
*
|
||||
* FUNCTION: acpi_ut_check_and_repair_ascii
|
||||
*
|
||||
* PARAMETERS: name - Ascii string
|
||||
* count - Number of characters to check
|
||||
*
|
||||
* RETURN: None
|
||||
*
|
||||
* DESCRIPTION: Ensure that the requested number of characters are printable
|
||||
* Ascii characters. Sets non-printable and null chars to <space>.
|
||||
*
|
||||
******************************************************************************/
|
||||
|
||||
void acpi_ut_check_and_repair_ascii(u8 *name, char *repaired_name, u32 count)
|
||||
{
|
||||
u32 i;
|
||||
|
||||
for (i = 0; i < count; i++) {
|
||||
repaired_name[i] = (char)name[i];
|
||||
|
||||
if (!name[i]) {
|
||||
return;
|
||||
}
|
||||
if (!isprint(name[i])) {
|
||||
repaired_name[i] = ' ';
|
||||
}
|
||||
}
|
||||
}
|
|
@ -143,73 +143,6 @@ void acpi_ut_print_string(char *string, u16 max_length)
|
|||
}
|
||||
}
|
||||
|
||||
/*******************************************************************************
|
||||
*
|
||||
* FUNCTION: acpi_ut_valid_acpi_char
|
||||
*
|
||||
* PARAMETERS: char - The character to be examined
|
||||
* position - Byte position (0-3)
|
||||
*
|
||||
* RETURN: TRUE if the character is valid, FALSE otherwise
|
||||
*
|
||||
* DESCRIPTION: Check for a valid ACPI character. Must be one of:
|
||||
* 1) Upper case alpha
|
||||
* 2) numeric
|
||||
* 3) underscore
|
||||
*
|
||||
* We allow a '!' as the last character because of the ASF! table
|
||||
*
|
||||
******************************************************************************/
|
||||
|
||||
u8 acpi_ut_valid_acpi_char(char character, u32 position)
|
||||
{
|
||||
|
||||
if (!((character >= 'A' && character <= 'Z') ||
|
||||
(character >= '0' && character <= '9') || (character == '_'))) {
|
||||
|
||||
/* Allow a '!' in the last position */
|
||||
|
||||
if (character == '!' && position == 3) {
|
||||
return (TRUE);
|
||||
}
|
||||
|
||||
return (FALSE);
|
||||
}
|
||||
|
||||
return (TRUE);
|
||||
}
|
||||
|
||||
/*******************************************************************************
|
||||
*
|
||||
* FUNCTION: acpi_ut_valid_acpi_name
|
||||
*
|
||||
* PARAMETERS: name - The name to be examined. Does not have to
|
||||
* be NULL terminated string.
|
||||
*
|
||||
* RETURN: TRUE if the name is valid, FALSE otherwise
|
||||
*
|
||||
* DESCRIPTION: Check for a valid ACPI name. Each character must be one of:
|
||||
* 1) Upper case alpha
|
||||
* 2) numeric
|
||||
* 3) underscore
|
||||
*
|
||||
******************************************************************************/
|
||||
|
||||
u8 acpi_ut_valid_acpi_name(char *name)
|
||||
{
|
||||
u32 i;
|
||||
|
||||
ACPI_FUNCTION_ENTRY();
|
||||
|
||||
for (i = 0; i < ACPI_NAME_SIZE; i++) {
|
||||
if (!acpi_ut_valid_acpi_char(name[i], i)) {
|
||||
return (FALSE);
|
||||
}
|
||||
}
|
||||
|
||||
return (TRUE);
|
||||
}
|
||||
|
||||
/*******************************************************************************
|
||||
*
|
||||
* FUNCTION: acpi_ut_repair_name
|
||||
|
@ -253,7 +186,7 @@ void acpi_ut_repair_name(char *name)
|
|||
/* Check each character in the name */
|
||||
|
||||
for (i = 0; i < ACPI_NAME_SIZE; i++) {
|
||||
if (acpi_ut_valid_acpi_char(name[i], i)) {
|
||||
if (acpi_ut_valid_name_char(name[i], i)) {
|
||||
continue;
|
||||
}
|
||||
|
||||
|
|
|
@ -31,6 +31,7 @@ TOOL_OBJS = \
|
|||
osunixxf.o\
|
||||
tbprint.o\
|
||||
tbxfroot.o\
|
||||
utascii.o\
|
||||
utbuffer.o\
|
||||
utdebug.o\
|
||||
utexcep.o\
|
||||
|
|
|
@ -68,7 +68,7 @@ u8 ap_is_valid_header(struct acpi_table_header *table)
|
|||
|
||||
/* Make sure signature is all ASCII and a valid ACPI name */
|
||||
|
||||
if (!acpi_ut_valid_acpi_name(table->signature)) {
|
||||
if (!acpi_ut_valid_nameseg(table->signature)) {
|
||||
acpi_log_error("Table signature (0x%8.8X) is invalid\n",
|
||||
*(u32 *)table->signature);
|
||||
return (FALSE);
|
||||
|
@ -407,6 +407,12 @@ int ap_dump_table_from_file(char *pathname)
|
|||
return (-1);
|
||||
}
|
||||
|
||||
if (!acpi_ut_valid_nameseg(table->signature)) {
|
||||
acpi_log_error
|
||||
("No valid ACPI signature was found in input file %s\n",
|
||||
pathname);
|
||||
}
|
||||
|
||||
/* File must be at least as long as the table length */
|
||||
|
||||
if (table->length > file_size) {
|
||||
|
|
Loading…
Reference in New Issue