tomoyo: cleanup. don't store bogus pointer
If domain is NULL then &domain->list is a bogus address. Let's leave head->r.domain NULL instead of saving an unusable pointer. This is just a cleanup. The current code always checks head->r.eof before dereferencing head->r.domain. Signed-off-by: Dan Carpenter <error27@gmail.com> Acked-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
This commit is contained in:
parent
f6f94e2ab1
commit
68eda8f590
|
@ -768,8 +768,10 @@ static bool tomoyo_select_one(struct tomoyo_io_buffer *head, const char *data)
|
|||
return true; /* Do nothing if open(O_WRONLY). */
|
||||
memset(&head->r, 0, sizeof(head->r));
|
||||
head->r.print_this_domain_only = true;
|
||||
head->r.eof = !domain;
|
||||
head->r.domain = &domain->list;
|
||||
if (domain)
|
||||
head->r.domain = &domain->list;
|
||||
else
|
||||
head->r.eof = 1;
|
||||
tomoyo_io_printf(head, "# select %s\n", data);
|
||||
if (domain && domain->is_deleted)
|
||||
tomoyo_io_printf(head, "# This is a deleted domain.\n");
|
||||
|
|
Loading…
Reference in New Issue