hollalinux
/
linux-sg2042
mirror of https://github.com/sophgo/linux-riscv.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

platform/x86: fujitsu-laptop: allocate fujitsu_bl in acpi_fujitsu_bl_add() 

Only allocate memory for struct fujitsu_bl when the FUJ02B1 ACPI device
is present.  Use devm_kzalloc() for allocating memory to simplify
cleanup.

Due to the fact that the power property of the backlight device created
by the backlight driver is accessed from acpi_fujitsu_laptop_add(),
pointer to the allocated memory will remain stored in a module-wide
variable until the backlight driver is extracted into a separate module.

Signed-off-by: Michał Kępień <kernel@kempniu.pl>
Reviewed-by: Jonathan Woithe <jwoithe@just42.net>
Signed-off-by: Darren Hart (VMware) <dvhart@infradead.org>
This commit is contained in:
Michał Kępień 2017-05-19 09:44:42 +02:00 committed by Darren Hart (VMware)
parent 7ec3b54d16
commit 679374e49c
1 changed files with 9 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
drivers/platform/x86/fujitsu-laptop.c
View File

@ -392,6 +392,7 @@ static int fujitsu_backlight_register(struct acpi_device *device)
static int acpi_fujitsu_bl_add(struct acpi_device *device) static int acpi_fujitsu_bl_add(struct acpi_device *device)
{ {
struct fujitsu_bl *priv;
int state = 0; int state = 0;
int error; int error;
@ -401,10 +402,15 @@ static int acpi_fujitsu_bl_add(struct acpi_device *device)
if (!device) if (!device)
return -EINVAL; return -EINVAL;
priv = devm_kzalloc(&device->dev, sizeof(*priv), GFP_KERNEL);
if (!priv)
return -ENOMEM;
fujitsu_bl = priv;
fujitsu_bl->acpi_handle = device->handle; fujitsu_bl->acpi_handle = device->handle;
sprintf(acpi_device_name(device), "%s", ACPI_FUJITSU_BL_DEVICE_NAME); sprintf(acpi_device_name(device), "%s", ACPI_FUJITSU_BL_DEVICE_NAME);
sprintf(acpi_device_class(device), "%s", ACPI_FUJITSU_CLASS); sprintf(acpi_device_class(device), "%s", ACPI_FUJITSU_CLASS);
device->driver_data = fujitsu_bl; device->driver_data = priv;
error = acpi_fujitsu_bl_input_setup(device); error = acpi_fujitsu_bl_input_setup(device);
if (error) if (error)
@ -837,7 +843,7 @@ static int acpi_fujitsu_laptop_add(struct acpi_device *device)
pr_info("BTNI: [0x%x]\n", call_fext_func(FUNC_BUTTONS, 0x0, 0x0, 0x0)); pr_info("BTNI: [0x%x]\n", call_fext_func(FUNC_BUTTONS, 0x0, 0x0, 0x0));
/* Sync backlight power status */ /* Sync backlight power status */
if (fujitsu_bl->bl_device && if (fujitsu_bl && fujitsu_bl->bl_device &&
acpi_video_get_backlight_type() == acpi_backlight_vendor) { acpi_video_get_backlight_type() == acpi_backlight_vendor) {
if (call_fext_func(FUNC_BACKLIGHT, 0x2, 0x4, 0x0) == 3) if (call_fext_func(FUNC_BACKLIGHT, 0x2, 0x4, 0x0) == 3)
fujitsu_bl->bl_device->props.power = FB_BLANK_POWERDOWN; fujitsu_bl->bl_device->props.power = FB_BLANK_POWERDOWN;
@ -995,13 +1001,9 @@ static int __init fujitsu_init(void)
if (acpi_disabled) if (acpi_disabled)
return -ENODEV; return -ENODEV;
fujitsu_bl = kzalloc(sizeof(struct fujitsu_bl), GFP_KERNEL);
if (!fujitsu_bl)
return -ENOMEM;
ret = acpi_bus_register_driver(&acpi_fujitsu_bl_driver); ret = acpi_bus_register_driver(&acpi_fujitsu_bl_driver);
if (ret) if (ret)
goto err_free_fujitsu_bl; return ret;
/* Register platform stuff */ /* Register platform stuff */
@ -1031,8 +1033,6 @@ err_unregister_platform_driver:
platform_driver_unregister(&fujitsu_pf_driver); platform_driver_unregister(&fujitsu_pf_driver);
err_unregister_acpi: err_unregister_acpi:
acpi_bus_unregister_driver(&acpi_fujitsu_bl_driver); acpi_bus_unregister_driver(&acpi_fujitsu_bl_driver);
err_free_fujitsu_bl:
kfree(fujitsu_bl);
return ret; return ret;
} }
@ -1047,8 +1047,6 @@ static void __exit fujitsu_cleanup(void)
acpi_bus_unregister_driver(&acpi_fujitsu_bl_driver); acpi_bus_unregister_driver(&acpi_fujitsu_bl_driver);
kfree(fujitsu_bl);
pr_info("driver unloaded\n"); pr_info("driver unloaded\n");
} }