hollalinux
/
linux-sg2042
mirror of https://github.com/sophgo/linux-riscv.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

drm/pl111: Fix return value check in pl111_amba_probe() 

In case of error, the function devm_ioremap_resource() returns ERR_PTR()
and never returns NULL. The NULL test in the return value check should
be replaced with IS_ERR().

Fixes: bed41005e6 ("drm/pl111: Initial drm/kms driver for pl111")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Reviewed-by: Eric Anholt <eric@anholt.net>
Link: http://patchwork.freedesktop.org/patch/msgid/20170521010152.6186-1-weiyj.lk@gmail.com
This commit is contained in:
Wei Yongjun 2017-05-21 01:01:52 +00:00 committed by Eric Anholt
parent f90dee20b4
commit 665f37e7ee
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/gpu/drm/pl111/pl111_drv.c
View File

@ -200,9 +200,9 @@ static int pl111_amba_probe(struct amba_device *amba_dev,
drm->dev_private = priv;
priv->regs = devm_ioremap_resource(dev, &amba_dev->res);
if (!priv->regs) {
if (IS_ERR(priv->regs)) {
dev_err(dev, "%s failed mmio\n", __func__);
return -EINVAL;
return PTR_ERR(priv->regs);
}
/* turn off interrupts before requesting the irq */