hollalinux
/
linux-sg2042
mirror of https://github.com/sophgo/linux-riscv.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

net: vrf: Remove direct access to skb->data 

Nik pointed that the VRF driver should be using skb_header_pointer
instead of accessing skb->data and bits beyond directly which can
be garbage.

Fixes: 35402e3136 ("net: Add IPv6 support to VRF device")
Cc: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Signed-off-by: David Ahern <dsa@cumulusnetworks.com>
Signed-off-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
David Ahern 2016-02-23 10:10:26 -08:00 committed by David S. Miller
parent ee50c130c8
commit 65c38aa653
1 changed files with 8 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
drivers/net/vrf.c
View File

@ -104,20 +104,23 @@ static struct dst_ops vrf_dst_ops = {
#if IS_ENABLED(CONFIG_IPV6) #if IS_ENABLED(CONFIG_IPV6)
static bool check_ipv6_frame(const struct sk_buff *skb) static bool check_ipv6_frame(const struct sk_buff *skb)
{ {
const struct ipv6hdr *ipv6h = (struct ipv6hdr *)skb->data; const struct ipv6hdr *ipv6h;
size_t hlen = sizeof(*ipv6h); struct ipv6hdr _ipv6h;
bool rc = true; bool rc = true;
if (skb->len < hlen) ipv6h = skb_header_pointer(skb, 0, sizeof(_ipv6h), &_ipv6h);
if (!ipv6h)
goto out; goto out;
if (ipv6h->nexthdr == NEXTHDR_ICMP) { if (ipv6h->nexthdr == NEXTHDR_ICMP) {
const struct icmp6hdr *icmph; const struct icmp6hdr *icmph;
struct icmp6hdr _icmph;
if (skb->len < hlen + sizeof(*icmph)) icmph = skb_header_pointer(skb, sizeof(_ipv6h),
sizeof(_icmph), &_icmph);
if (!icmph)
goto out; goto out;
icmph = (struct icmp6hdr *)(skb->data + sizeof(*ipv6h));
switch (icmph->icmp6_type) { switch (icmph->icmp6_type) {
case NDISC_ROUTER_SOLICITATION: case NDISC_ROUTER_SOLICITATION:
case NDISC_ROUTER_ADVERTISEMENT: case NDISC_ROUTER_ADVERTISEMENT: