xfs: remove incorrect log write optimization
We do need a barrier for the first buffer of a split log write. Otherwise we might incorrectly stamp the tail LSN into transactions in the first part of the split write, or not flush data I/O before updating the inode size. Signed-off-by: Christoph Hellwig <hch@lst.de> Signed-off-by: Alex Elder <aelder@sgi.com>
This commit is contained in:
parent
2727ccc950
commit
651701d71d
|
@ -1423,11 +1423,8 @@ xlog_sync(xlog_t *log,
|
||||||
XFS_BUF_BUSY(bp);
|
XFS_BUF_BUSY(bp);
|
||||||
XFS_BUF_ASYNC(bp);
|
XFS_BUF_ASYNC(bp);
|
||||||
bp->b_flags |= XBF_LOG_BUFFER;
|
bp->b_flags |= XBF_LOG_BUFFER;
|
||||||
/*
|
|
||||||
* Do an ordered write for the log block.
|
if (log->l_mp->m_flags & XFS_MOUNT_BARRIER)
|
||||||
* Its unnecessary to flush the first split block in the log wrap case.
|
|
||||||
*/
|
|
||||||
if (!split && (log->l_mp->m_flags & XFS_MOUNT_BARRIER))
|
|
||||||
XFS_BUF_ORDERED(bp);
|
XFS_BUF_ORDERED(bp);
|
||||||
|
|
||||||
ASSERT(XFS_BUF_ADDR(bp) <= log->l_logBBsize-1);
|
ASSERT(XFS_BUF_ADDR(bp) <= log->l_logBBsize-1);
|
||||||
|
|
Loading…
Reference in New Issue