hollalinux
/
linux-sg2042
mirror of https://github.com/sophgo/linux-riscv.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

i2c: sh_mobile: refactor rx isr 

Remove the do_while loop which was just there to have an easy exit with
"break;" and replace it with if-else-blocks which should make the state
machine clearer.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
This commit is contained in:
Wolfram Sang 2019-01-16 22:05:54 +01:00 committed by Wolfram Sang
parent 0130e3bfa9
commit 63c5246003
1 changed files with 22 additions and 30 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

52
drivers/i2c/busses/i2c-sh_mobile.c
View File

@ -373,39 +373,31 @@ static int sh_mobile_i2c_isr_rx(struct sh_mobile_i2c_data *pd)
unsigned char data; unsigned char data;
int real_pos; int real_pos;
do { real_pos = pd->pos - 2;
if (pd->pos == -1) {
i2c_op(pd, OP_TX_FIRST); if (pd->pos == -1) {
break; i2c_op(pd, OP_TX_FIRST);
} else if (pd->pos == 0) {
i2c_op(pd, OP_TX_TO_RX);
} else if (pd->pos == pd->msg->len) {
if (pd->stop_after_dma) {
/* Simulate PIO end condition after DMA transfer */
i2c_op(pd, OP_RX_STOP);
pd->pos++;
goto done;
} }
if (pd->pos == 0) { if (real_pos < 0)
i2c_op(pd, OP_TX_TO_RX); i2c_op(pd, OP_RX_STOP);
break; else
} data = i2c_op(pd, OP_RX_STOP_DATA);
} else if (real_pos >= 0) {
real_pos = pd->pos - 2; data = i2c_op(pd, OP_RX);
}
if (pd->pos == pd->msg->len) {
if (pd->stop_after_dma) {
/* Simulate PIO end condition after DMA transfer */
i2c_op(pd, OP_RX_STOP);
pd->pos++;
break;
}
if (real_pos < 0)
i2c_op(pd, OP_RX_STOP);
else
data = i2c_op(pd, OP_RX_STOP_DATA);
} else if (real_pos >= 0) {
data = i2c_op(pd, OP_RX);
}
if (real_pos >= 0)
pd->msg->buf[real_pos] = data;
} while (0);
if (real_pos >= 0)
pd->msg->buf[real_pos] = data;
done:
pd->pos++; pd->pos++;
return pd->pos == (pd->msg->len + 2); return pd->pos == (pd->msg->len + 2);
} }