pinctrl/samsung: Fix race in installing chained IRQ handler
Fix a race where a pending interrupt could be received and the handler called before the handler's data has been setup, by converting to irq_set_chained_handler_and_data(). Search and conversion was done with coccinelle: @@ expression E1, E2, E3; @@ ( -if (irq_set_chained_handler(E1, E3) != 0) - BUG(); | -irq_set_chained_handler(E1, E3); ) -irq_set_handler_data(E1, E2); +irq_set_chained_handler_and_data(E1, E3, E2); @@ expression E1, E2, E3; @@ ( -if (irq_set_chained_handler(E1, E3) != 0) - BUG(); ... | -irq_set_chained_handler(E1, E3); ... ) -irq_set_handler_data(E1, E2); +irq_set_chained_handler_and_data(E1, E3, E2); Reported-by: Russell King <rmk+kernel@arm.linux.org.uk> Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Cc: Julia Lawall <Julia.Lawall@lip6.fr> Cc: Tomasz Figa <tomasz.figa@gmail.com> Cc: Thomas Abraham <thomas.abraham@linaro.org> Cc: Linus Walleij <linus.walleij@linaro.org> Cc: linux-arm-kernel@lists.infradead.org Cc: linux-samsung-soc@vger.kernel.org Cc: linux-gpio@vger.kernel.org
This commit is contained in:
parent
0cfc45cfdf
commit
623a650ebc
|
@ -506,8 +506,7 @@ static int s3c64xx_eint_gpio_init(struct samsung_pinctrl_drv_data *d)
|
|||
data->domains[nr_domains++] = bank->irq_domain;
|
||||
}
|
||||
|
||||
irq_set_chained_handler(d->irq, s3c64xx_eint_gpio_irq);
|
||||
irq_set_handler_data(d->irq, data);
|
||||
irq_set_chained_handler_and_data(d->irq, s3c64xx_eint_gpio_irq, data);
|
||||
|
||||
return 0;
|
||||
}
|
||||
|
@ -731,8 +730,9 @@ static int s3c64xx_eint_eint0_init(struct samsung_pinctrl_drv_data *d)
|
|||
return -ENXIO;
|
||||
}
|
||||
|
||||
irq_set_chained_handler(irq, s3c64xx_eint0_handlers[i]);
|
||||
irq_set_handler_data(irq, data);
|
||||
irq_set_chained_handler_and_data(irq,
|
||||
s3c64xx_eint0_handlers[i],
|
||||
data);
|
||||
}
|
||||
|
||||
bank = d->pin_banks;
|
||||
|
|
Loading…
Reference in New Issue