USB: garmin_gps: fix memory leak on disconnect
Remove bogus disconnect test introduced by 95bef012e
("USB: more serial
drivers writing after disconnect") which prevented queued data from
being freed on disconnect.
The possible IO it was supposed to prevent is long gone.
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Johan Hovold <jhovold@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
parent
cb25505fc6
commit
618aa1068d
|
@ -956,9 +956,6 @@ static void garmin_close(struct usb_serial_port *port)
|
||||||
if (!serial)
|
if (!serial)
|
||||||
return;
|
return;
|
||||||
|
|
||||||
mutex_lock(&port->serial->disc_mutex);
|
|
||||||
|
|
||||||
if (!port->serial->disconnected)
|
|
||||||
garmin_clear(garmin_data_p);
|
garmin_clear(garmin_data_p);
|
||||||
|
|
||||||
/* shutdown our urbs */
|
/* shutdown our urbs */
|
||||||
|
@ -968,8 +965,6 @@ static void garmin_close(struct usb_serial_port *port)
|
||||||
/* keep reset state so we know that we must start a new session */
|
/* keep reset state so we know that we must start a new session */
|
||||||
if (garmin_data_p->state != STATE_RESET)
|
if (garmin_data_p->state != STATE_RESET)
|
||||||
garmin_data_p->state = STATE_DISCONNECTED;
|
garmin_data_p->state = STATE_DISCONNECTED;
|
||||||
|
|
||||||
mutex_unlock(&port->serial->disc_mutex);
|
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
||||||
|
|
Loading…
Reference in New Issue