hollalinux
/
linux-sg2042
mirror of https://github.com/sophgo/linux-riscv.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

SUNRPC: svc_tcp_recvfrom cleanup 

Minor cleanup in preparation for later patches.

Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
This commit is contained in:
Trond Myklebust 2009-05-18 17:47:56 -04:00 committed by J. Bruce Fields
parent 0601f79392
commit 5ee78d483c
1 changed files with 15 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

34
net/sunrpc/svcsock.c
View File

@ -893,6 +893,7 @@ failed:
static int svc_tcp_recv_record(struct svc_sock *svsk, struct svc_rqst *rqstp) static int svc_tcp_recv_record(struct svc_sock *svsk, struct svc_rqst *rqstp)
{ {
struct svc_serv *serv = svsk->sk_xprt.xpt_server; struct svc_serv *serv = svsk->sk_xprt.xpt_server;
unsigned int want;
int len; int len;
if (test_and_clear_bit(XPT_CHNGBUF, &svsk->sk_xprt.xpt_flags)) if (test_and_clear_bit(XPT_CHNGBUF, &svsk->sk_xprt.xpt_flags))
@ -915,9 +916,9 @@ static int svc_tcp_recv_record(struct svc_sock *svsk, struct svc_rqst *rqstp)
clear_bit(XPT_DATA, &svsk->sk_xprt.xpt_flags); clear_bit(XPT_DATA, &svsk->sk_xprt.xpt_flags);
if (svsk->sk_tcplen < sizeof(rpc_fraghdr)) { if (svsk->sk_tcplen < sizeof(rpc_fraghdr)) {
int want = sizeof(rpc_fraghdr) - svsk->sk_tcplen;
struct kvec iov; struct kvec iov;
want = sizeof(rpc_fraghdr) - svsk->sk_tcplen;
iov.iov_base = ((char *) &svsk->sk_reclen) + svsk->sk_tcplen; iov.iov_base = ((char *) &svsk->sk_reclen) + svsk->sk_tcplen;
iov.iov_len = want; iov.iov_len = want;
if ((len = svc_recvfrom(rqstp, &iov, 1, want)) < 0) if ((len = svc_recvfrom(rqstp, &iov, 1, want)) < 0)
@ -1040,8 +1041,9 @@ static int svc_tcp_recvfrom(struct svc_rqst *rqstp)
struct svc_serv *serv = svsk->sk_xprt.xpt_server; struct svc_serv *serv = svsk->sk_xprt.xpt_server;
int len; int len;
struct kvec *vec; struct kvec *vec;
int pnum, vlen;
struct rpc_rqst *req = NULL; struct rpc_rqst *req = NULL;
unsigned int vlen;
int pnum;
dprintk("svc: tcp_recv %p data %d conn %d close %d\n", dprintk("svc: tcp_recv %p data %d conn %d close %d\n",
svsk, test_bit(XPT_DATA, &svsk->sk_xprt.xpt_flags), svsk, test_bit(XPT_DATA, &svsk->sk_xprt.xpt_flags),
@ -1072,7 +1074,7 @@ static int svc_tcp_recvfrom(struct svc_rqst *rqstp)
} }
pnum = 1; pnum = 1;
while (vlen < len) { while (vlen < svsk->sk_reclen - 8) {
vec[pnum].iov_base = (req) ? vec[pnum].iov_base = (req) ?
page_address(req->rq_private_buf.pages[pnum - 1]) : page_address(req->rq_private_buf.pages[pnum - 1]) :
page_address(rqstp->rq_pages[pnum]); page_address(rqstp->rq_pages[pnum]);
@ -1083,29 +1085,23 @@ static int svc_tcp_recvfrom(struct svc_rqst *rqstp)
rqstp->rq_respages = &rqstp->rq_pages[pnum]; rqstp->rq_respages = &rqstp->rq_pages[pnum];
/* Now receive data */ /* Now receive data */
len = svc_recvfrom(rqstp, vec, pnum, len); len = svc_recvfrom(rqstp, vec, pnum, svsk->sk_reclen - 8);
if (len < 0) if (len < 0)
goto err_again; goto err_again;
/*
* Account for the 8 bytes we read earlier
*/
len += 8;
if (req) { if (req) {
xprt_complete_rqst(req->rq_task, len); xprt_complete_rqst(req->rq_task, svsk->sk_reclen);
len = 0; rqstp->rq_arg.len = 0;
goto out; goto out;
} }
dprintk("svc: TCP complete record (%d bytes)\n", len); dprintk("svc: TCP complete record (%d bytes)\n", svsk->sk_reclen);
rqstp->rq_arg.len = len; rqstp->rq_arg.len = svsk->sk_reclen;
rqstp->rq_arg.page_base = 0; rqstp->rq_arg.page_base = 0;
if (len <= rqstp->rq_arg.head[0].iov_len) { if (rqstp->rq_arg.len <= rqstp->rq_arg.head[0].iov_len) {
rqstp->rq_arg.head[0].iov_len = len; rqstp->rq_arg.head[0].iov_len = rqstp->rq_arg.len;
rqstp->rq_arg.page_len = 0; rqstp->rq_arg.page_len = 0;
} else { } else
rqstp->rq_arg.page_len = len - rqstp->rq_arg.head[0].iov_len; rqstp->rq_arg.page_len = rqstp->rq_arg.len - rqstp->rq_arg.head[0].iov_len;
}
rqstp->rq_xprt_ctxt = NULL; rqstp->rq_xprt_ctxt = NULL;
rqstp->rq_prot = IPPROTO_TCP; rqstp->rq_prot = IPPROTO_TCP;
@ -1123,7 +1119,7 @@ out:
if (serv->sv_stats) if (serv->sv_stats)
serv->sv_stats->nettcpcnt++; serv->sv_stats->nettcpcnt++;
return len; return rqstp->rq_arg.len;
err_again: err_again:
if (len == -EAGAIN) { if (len == -EAGAIN) {