hollalinux
/
linux-sg2042
mirror of https://github.com/sophgo/linux-riscv.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

leds/leds-s3c24xx: use devm_gpio_request 

why?
because if the led_classdev_register fails we wont do gpio free
because using devm_ functions, there is no need for error paths

Signed-off-by: Devendra Naga <devendra.aaru@gmail.com>
Signed-off-by: Bryan Wu <bryan.wu@canonical.com>
This commit is contained in:
Devendra Naga 2012-07-11 17:50:32 +08:00 committed by Bryan Wu
parent a209f76698
commit 5ecf6e40bb
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/leds/leds-s3c24xx.c
View File

@ -65,7 +65,6 @@ static int s3c24xx_led_remove(struct platform_device *dev)
struct s3c24xx_gpio_led *led = pdev_to_gpio(dev); struct s3c24xx_gpio_led *led = pdev_to_gpio(dev);
led_classdev_unregister(&led->cdev); led_classdev_unregister(&led->cdev);
gpio_free(led->pdata->gpio);
return 0; return 0;
} }
@ -92,7 +91,7 @@ static int s3c24xx_led_probe(struct platform_device *dev)
led->pdata = pdata; led->pdata = pdata;
ret = gpio_request(pdata->gpio, "S3C24XX_LED"); ret = devm_gpio_request(&dev->dev, pdata->gpio, "S3C24XX_LED");
if (ret < 0) if (ret < 0)
return ret; return ret;