hollalinux
/
linux-sg2042
mirror of https://github.com/sophgo/linux-riscv.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

staging: iio: meter: remove fixme comment on device remove 

This comment was in place in the original drafts of these drivers
when the remove function did a whole lot of work: flushed queues,
unregistered interrupts, uninitialized rings, unconfigured rings,
and a few kfree's.

The remove functions have since been reduced to unregistering and
stopping the device.  This is the inverse of what was done during
probe and is correct. Time to remove the comment.

Signed-off-by: Alison Schofield <amsfield22@gmail.com>
Acked-by: Daniel Baluta <daniel.baluta@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Alison Schofield 2016-03-13 23:11:30 -07:00 committed by Greg Kroah-Hartman
parent b026338289
commit 5e3d1d520f
3 changed files with 0 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
drivers/staging/iio/meter/ade7753.c
View File

@ -528,7 +528,6 @@ static int ade7753_probe(struct spi_device *spi)
return iio_device_register(indio_dev); return iio_device_register(indio_dev);
} }
/* fixme, confirm ordering in this function */
static int ade7753_remove(struct spi_device *spi) static int ade7753_remove(struct spi_device *spi)
{ {
struct iio_dev *indio_dev = spi_get_drvdata(spi); struct iio_dev *indio_dev = spi_get_drvdata(spi);

1
drivers/staging/iio/meter/ade7754.c
View File

@ -558,7 +558,6 @@ powerdown_on_error:
return ret; return ret;
} }
/* fixme, confirm ordering in this function */
static int ade7754_remove(struct spi_device *spi) static int ade7754_remove(struct spi_device *spi)
{ {
struct iio_dev *indio_dev = spi_get_drvdata(spi); struct iio_dev *indio_dev = spi_get_drvdata(spi);

1
drivers/staging/iio/meter/ade7759.c
View File

@ -476,7 +476,6 @@ static int ade7759_probe(struct spi_device *spi)
return iio_device_register(indio_dev); return iio_device_register(indio_dev);
} }
/* fixme, confirm ordering in this function */
static int ade7759_remove(struct spi_device *spi) static int ade7759_remove(struct spi_device *spi)
{ {
struct iio_dev *indio_dev = spi_get_drvdata(spi); struct iio_dev *indio_dev = spi_get_drvdata(spi);