hollalinux
/
linux-sg2042
mirror of https://github.com/sophgo/linux-riscv.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

vfs: Fix invalid ida_remove() call 

When the group id of a shared mount is not allocated, the umount still
tries to call mnt_release_group_id(), which eventually hits a kernel
warning at ida_remove() spewing a message like:
  ida_remove called for id=0 which is not allocated.

This patch fixes the bug simply checking the group id in the caller.

Reported-by: Cristian Rodríguez <crrodriguez@opensuse.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
This commit is contained in:
Takashi Iwai 2013-05-10 14:04:11 +02:00 committed by Al Viro
parent a93cb29aca
commit 5d477b6079
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
fs/pnode.c
View File

@ -83,7 +83,8 @@ static int do_make_slave(struct mount *mnt)
if (peer_mnt == mnt) if (peer_mnt == mnt)
peer_mnt = NULL; peer_mnt = NULL;
} }
if (IS_MNT_SHARED(mnt) && list_empty(&mnt->mnt_share)) if (mnt->mnt_group_id && IS_MNT_SHARED(mnt) &&
list_empty(&mnt->mnt_share))
mnt_release_group_id(mnt); mnt_release_group_id(mnt);
list_del_init(&mnt->mnt_share); list_del_init(&mnt->mnt_share);