hollalinux
/
linux-sg2042
mirror of https://github.com/sophgo/linux-riscv.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

dmaengine: imx-sdma: explicitly freeup irq 

dmaengine device should explicitly call devm_free_irq() when using
devm_request_irq().

The irq is still ON when devices remove is executed and irq should be
quiesced before remove is completed.

Signed-off-by: Vinod Koul <vinod.koul@intel.com>
Cc: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Fabio Estevam <fabio.estevam@freescale.com>
This commit is contained in:
Vinod Koul 2016-07-03 00:00:55 +05:30
parent 71c6b66349
commit 5bb9dbb5ae
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/dma/imx-sdma.c
View File

@ -386,6 +386,7 @@ struct sdma_engine {
const struct sdma_driver_data *drvdata; const struct sdma_driver_data *drvdata;
u32 spba_start_addr; u32 spba_start_addr;
u32 spba_end_addr; u32 spba_end_addr;
unsigned int irq;
}; };
static struct sdma_driver_data sdma_imx31 = { static struct sdma_driver_data sdma_imx31 = {
@ -1708,6 +1709,8 @@ static int sdma_probe(struct platform_device *pdev)
if (ret) if (ret)
return ret; return ret;
sdma->irq = irq;
sdma->script_addrs = kzalloc(sizeof(*sdma->script_addrs), GFP_KERNEL); sdma->script_addrs = kzalloc(sizeof(*sdma->script_addrs), GFP_KERNEL);
if (!sdma->script_addrs) if (!sdma->script_addrs)
return -ENOMEM; return -ENOMEM;
@ -1833,6 +1836,7 @@ static int sdma_remove(struct platform_device *pdev)
struct sdma_engine *sdma = platform_get_drvdata(pdev); struct sdma_engine *sdma = platform_get_drvdata(pdev);
int i; int i;
devm_free_irq(&pdev->dev, sdma->irq, sdma);
dma_async_device_unregister(&sdma->dma_device); dma_async_device_unregister(&sdma->dma_device);
kfree(sdma->script_addrs); kfree(sdma->script_addrs);
/* Kill the tasklet */ /* Kill the tasklet */