macsec: fix memory leaks when skb_to_sgvec fails
Fixes: cda7ea6903
("macsec: check return value of skb_to_sgvec always")
Signed-off-by: Sabrina Dubroca <sd@queasysnail.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
parent
c0576e3975
commit
5aba2ba503
|
@ -742,6 +742,7 @@ static struct sk_buff *macsec_encrypt(struct sk_buff *skb,
|
||||||
sg_init_table(sg, ret);
|
sg_init_table(sg, ret);
|
||||||
ret = skb_to_sgvec(skb, sg, 0, skb->len);
|
ret = skb_to_sgvec(skb, sg, 0, skb->len);
|
||||||
if (unlikely(ret < 0)) {
|
if (unlikely(ret < 0)) {
|
||||||
|
aead_request_free(req);
|
||||||
macsec_txsa_put(tx_sa);
|
macsec_txsa_put(tx_sa);
|
||||||
kfree_skb(skb);
|
kfree_skb(skb);
|
||||||
return ERR_PTR(ret);
|
return ERR_PTR(ret);
|
||||||
|
@ -954,6 +955,7 @@ static struct sk_buff *macsec_decrypt(struct sk_buff *skb,
|
||||||
sg_init_table(sg, ret);
|
sg_init_table(sg, ret);
|
||||||
ret = skb_to_sgvec(skb, sg, 0, skb->len);
|
ret = skb_to_sgvec(skb, sg, 0, skb->len);
|
||||||
if (unlikely(ret < 0)) {
|
if (unlikely(ret < 0)) {
|
||||||
|
aead_request_free(req);
|
||||||
kfree_skb(skb);
|
kfree_skb(skb);
|
||||||
return ERR_PTR(ret);
|
return ERR_PTR(ret);
|
||||||
}
|
}
|
||||||
|
|
Loading…
Reference in New Issue