hollalinux
/
linux-sg2042
mirror of https://github.com/sophgo/linux-riscv.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Staging: zram: Fix variable dereferenced before check 

This patch fixes the following Smatch warning in zram_drv.c-
drivers/staging/zram/zram_drv.c:899
destroy_device() warn: variable dereferenced before check 'zram->disk' (see line 896)

Acked-by: Minchan Kim <minchan@kernel.org>
Acked-by: Jerome Marchand <jmarchan@redhat.com>
Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Rashika Kheria 2013-10-30 18:43:32 +05:30 committed by Greg Kroah-Hartman
parent 238822bc91
commit 59d3fe5404
1 changed files with 3 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
drivers/staging/zram/zram_drv.c
View File

@ -896,13 +896,10 @@ static void destroy_device(struct zram *zram)
sysfs_remove_group(&disk_to_dev(zram->disk)->kobj, sysfs_remove_group(&disk_to_dev(zram->disk)->kobj,
&zram_disk_attr_group); &zram_disk_attr_group);
if (zram->disk) { del_gendisk(zram->disk);
del_gendisk(zram->disk); put_disk(zram->disk);
put_disk(zram->disk);
}
if (zram->queue) blk_cleanup_queue(zram->queue);
blk_cleanup_queue(zram->queue);
} }
static int __init zram_init(void) static int __init zram_init(void)