hollalinux
/
linux-sg2042
mirror of https://github.com/sophgo/linux-riscv.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

staging: unisys: Rework Kconfig dependencies 

I find the Kconfig dependencies of the various Unisys drivers rather
confusing. Due to the dependencies, you must select the drivers one by
one to see the following ones. So if you are looking for a specific
driver, it is not visible by default. And if you don't know exactly
what you need, it's even worse as you don't know what is available.

In a case like this with several helper drivers and many dependencies,
I think it makes more sense to list all the drivers at first, and use
select statements to fulfill the dependencies for the user.

As a nice side effect, it avoids the weird indentation, which was
technically correct but still somewhat confusing.

I also dropped the dependencies on HAS_IOMEM, as the whole driver set
is for X86_64 only anyway which always has HAS_IOMEM set. And I
dropped the redundant dependencies on UNISYSSPAR as all drivers are
already inside an "if UNISYSSPAR" block.

Signed-off-by: Jean Delvare <jdelvare@suse.de>
Cc: Benjamin Romer <benjamin.romer@unisys.com>
Cc: David Kershner <david.kershner@unisys.com>
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Jean Delvare 2015-02-21 13:16:34 +01:00 committed by Greg Kroah-Hartman
parent 58701e5a59
commit 59ce8d558c
6 changed files with 9 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/staging/unisys/uislib/Kconfig
View File

@ -4,7 +4,7 @@
config UNISYS_UISLIB
tristate "Unisys uislib driver"
depends on UNISYSSPAR && UNISYS_VISORCHIPSET && HAS_IOMEM
select UNISYS_VISORCHIPSET
---help---
If you say Y here, you will enable the Unisys uislib driver.

5
drivers/staging/unisys/virthba/Kconfig
View File

@ -4,7 +4,10 @@
config UNISYS_VIRTHBA
tristate "Unisys virthba driver"
depends on UNISYSSPAR && UNISYS_VISORCHIPSET && UNISYS_UISLIB && UNISYS_VIRTPCI && SCSI
depends on SCSI
select UNISYS_VISORCHIPSET
select UNISYS_UISLIB
select UNISYS_VIRTPCI
---help---
If you say Y here, you will enable the Unisys virthba driver.

2
drivers/staging/unisys/virtpci/Kconfig
View File

@ -4,7 +4,7 @@
config UNISYS_VIRTPCI
tristate "Unisys virtpci driver"
depends on UNISYSSPAR && UNISYS_UISLIB
select UNISYS_UISLIB
---help---
If you say Y here, you will enable the Unisys virtpci driver.

2
drivers/staging/unisys/visorchannel/Kconfig
View File

@ -4,7 +4,7 @@
config UNISYS_VISORCHANNEL
tristate "Unisys visorchannel driver"
depends on UNISYSSPAR && UNISYS_VISORUTIL
select UNISYS_VISORUTIL
---help---
If you say Y here, you will enable the Unisys visorchannel driver.

3
drivers/staging/unisys/visorchipset/Kconfig
View File

@ -4,7 +4,8 @@
config UNISYS_VISORCHIPSET
tristate "Unisys visorchipset driver"
depends on UNISYSSPAR && UNISYS_VISORUTIL && UNISYS_VISORCHANNEL && HAS_IOMEM
select UNISYS_VISORUTIL
select UNISYS_VISORCHANNEL
---help---
If you say Y here, you will enable the Unisys visorchipset driver.

1
drivers/staging/unisys/visorutil/Kconfig
View File

@ -4,7 +4,6 @@
config UNISYS_VISORUTIL
tristate "Unisys visorutil driver"
depends on UNISYSSPAR && HAS_IOMEM
---help---
If you say Y here, you will enable the Unisys visorutil driver.