btrfs: add assertion helpers for extent buffer read lock counters
The read_locks are a simple counter to track locking balance and used to assert tree locks. Add helpers to make it conditionally work only in DEBUG builds. Will be used in followup patches. Reviewed-by: Nikolay Borisov <nborisov@suse.com> Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de> Signed-off-by: David Sterba <dsterba@suse.com>
This commit is contained in:
parent
afd495a826
commit
58a2ddaedb
|
@ -12,8 +12,6 @@
|
||||||
#include "extent_io.h"
|
#include "extent_io.h"
|
||||||
#include "locking.h"
|
#include "locking.h"
|
||||||
|
|
||||||
static void btrfs_assert_tree_read_locked(struct extent_buffer *eb);
|
|
||||||
|
|
||||||
#ifdef CONFIG_BTRFS_DEBUG
|
#ifdef CONFIG_BTRFS_DEBUG
|
||||||
static void btrfs_assert_spinning_writers_get(struct extent_buffer *eb)
|
static void btrfs_assert_spinning_writers_get(struct extent_buffer *eb)
|
||||||
{
|
{
|
||||||
|
@ -43,12 +41,30 @@ static void btrfs_assert_spinning_readers_put(struct extent_buffer *eb)
|
||||||
atomic_dec(&eb->spinning_readers);
|
atomic_dec(&eb->spinning_readers);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
static void btrfs_assert_tree_read_locks_get(struct extent_buffer *eb)
|
||||||
|
{
|
||||||
|
atomic_inc(&eb->read_locks);
|
||||||
|
}
|
||||||
|
|
||||||
|
static void btrfs_assert_tree_read_locks_put(struct extent_buffer *eb)
|
||||||
|
{
|
||||||
|
atomic_dec(&eb->read_locks);
|
||||||
|
}
|
||||||
|
|
||||||
|
static void btrfs_assert_tree_read_locked(struct extent_buffer *eb)
|
||||||
|
{
|
||||||
|
BUG_ON(!atomic_read(&eb->read_locks));
|
||||||
|
}
|
||||||
|
|
||||||
#else
|
#else
|
||||||
static void btrfs_assert_spinning_writers_get(struct extent_buffer *eb) { }
|
static void btrfs_assert_spinning_writers_get(struct extent_buffer *eb) { }
|
||||||
static void btrfs_assert_spinning_writers_put(struct extent_buffer *eb) { }
|
static void btrfs_assert_spinning_writers_put(struct extent_buffer *eb) { }
|
||||||
static void btrfs_assert_no_spinning_writers(struct extent_buffer *eb) { }
|
static void btrfs_assert_no_spinning_writers(struct extent_buffer *eb) { }
|
||||||
static void btrfs_assert_spinning_readers_put(struct extent_buffer *eb) { }
|
static void btrfs_assert_spinning_readers_put(struct extent_buffer *eb) { }
|
||||||
static void btrfs_assert_spinning_readers_get(struct extent_buffer *eb) { }
|
static void btrfs_assert_spinning_readers_get(struct extent_buffer *eb) { }
|
||||||
|
static void btrfs_assert_tree_read_locked(struct extent_buffer *eb) { }
|
||||||
|
static void btrfs_assert_tree_read_locks_get(struct extent_buffer *eb) { }
|
||||||
|
static void btrfs_assert_tree_read_locks_put(struct extent_buffer *eb) { }
|
||||||
#endif
|
#endif
|
||||||
|
|
||||||
void btrfs_set_lock_blocking_read(struct extent_buffer *eb)
|
void btrfs_set_lock_blocking_read(struct extent_buffer *eb)
|
||||||
|
@ -309,8 +325,3 @@ void btrfs_assert_tree_locked(struct extent_buffer *eb)
|
||||||
{
|
{
|
||||||
BUG_ON(!atomic_read(&eb->write_locks));
|
BUG_ON(!atomic_read(&eb->write_locks));
|
||||||
}
|
}
|
||||||
|
|
||||||
static void btrfs_assert_tree_read_locked(struct extent_buffer *eb)
|
|
||||||
{
|
|
||||||
BUG_ON(!atomic_read(&eb->read_locks));
|
|
||||||
}
|
|
||||||
|
|
Loading…
Reference in New Issue