hollalinux
/
linux-sg2042
mirror of https://github.com/sophgo/linux-riscv.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

maiblox: mediatek: Fix handling of platform_get_irq() error 

platform_get_irq() returns -ERRNO on error.  In such case casting to u32
and comparing to 0 would pass the check.

Fixes: 623a6143a8 ("mailbox: mediatek: Add Mediatek CMDQ driver")
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Signed-off-by: Jassi Brar <jaswinder.singh@linaro.org>
This commit is contained in:
Krzysztof Kozlowski 2020-08-27 09:31:28 +02:00 committed by Jassi Brar
parent 7002ca237b
commit 558e4c36ec
1 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/mailbox/mtk-cmdq-mailbox.c
View File

@ -69,7 +69,7 @@ struct cmdq_task {
struct cmdq { struct cmdq {
struct mbox_controller mbox; struct mbox_controller mbox;
void __iomem *base; void __iomem *base;
u32 irq; int irq;
u32 thread_nr; u32 thread_nr;
u32 irq_mask; u32 irq_mask;
struct cmdq_thread *thread; struct cmdq_thread *thread;
@ -525,10 +525,8 @@ static int cmdq_probe(struct platform_device *pdev)
} }
cmdq->irq = platform_get_irq(pdev, 0); cmdq->irq = platform_get_irq(pdev, 0);
if (!cmdq->irq) { if (cmdq->irq < 0)
dev_err(dev, "failed to get irq\n"); return cmdq->irq;
return -EINVAL;
}
plat_data = (struct gce_plat *)of_device_get_match_data(dev); plat_data = (struct gce_plat *)of_device_get_match_data(dev);
if (!plat_data) { if (!plat_data) {