hollalinux
/
linux-sg2042
mirror of https://github.com/sophgo/linux-riscv.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

spmi: pmic-arb: Remove checking opc value not less than 0 

The opc parameter in pmic_arb_write_cmd() function is defined with type
u8 and it's always greater than or equal to 0. Checking that it's not
less than 0 is redundant and it can cause a forbidden warning during
compilation. Remove the check.

Signed-off-by: Fenglin Wu <fenglinw@codeaurora.org>
Signed-off-by: Kiran Gunda <kgunda@codeaurora.org>
Reviewed-by: Stephen Boyd <sboyd@codeaurora.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Fenglin Wu 2017-07-28 12:40:47 +05:30 committed by Greg Kroah-Hartman
parent 40f318f0ed
commit 53d296b594
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/spmi/spmi-pmic-arb.c
View File

@ -1,5 +1,5 @@
/* /*
* Copyright (c) 2012-2015, The Linux Foundation. All rights reserved. * Copyright (c) 2012-2015, 2017, The Linux Foundation. All rights reserved.
* *
* This program is free software; you can redistribute it and/or modify * This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License version 2 and * it under the terms of the GNU General Public License version 2 and
@ -419,7 +419,7 @@ static int pmic_arb_write_cmd(struct spmi_controller *ctrl, u8 opc, u8 sid,
/* Check the opcode */ /* Check the opcode */
if (opc >= 0x40 && opc <= 0x5F) if (opc >= 0x40 && opc <= 0x5F)
opc = PMIC_ARB_OP_WRITE; opc = PMIC_ARB_OP_WRITE;
else if (opc >= 0x00 && opc <= 0x0F) else if (opc <= 0x0F)
opc = PMIC_ARB_OP_EXT_WRITE; opc = PMIC_ARB_OP_EXT_WRITE;
else if (opc >= 0x30 && opc <= 0x37) else if (opc >= 0x30 && opc <= 0x37)
opc = PMIC_ARB_OP_EXT_WRITEL; opc = PMIC_ARB_OP_EXT_WRITEL;