hollalinux
/
linux-sg2042
mirror of https://github.com/sophgo/linux-riscv.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

regulator: max8660 - fix a memory leak in max8660_remove() 

In max8660_probe(), we allocate memory for max660.
In max8660_remove(), current implementation only free rdev
which is a member of struct max8660.
Thus, there is a small memory leak when we unload the module.

This patch fixes the memory leak by passing max660 to i2c clientdata,
and properly kfree(max8660) in max8660_remove().

Signed-off-by: Axel Lin <axel.lin@gmail.com>
Acked-by: Wolfram Sang <w.sang@pengutronix.de>
Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Signed-off-by: Liam Girdwood <lrg@slimlogic.co.uk>
This commit is contained in:
Axel Lin 2010-08-06 13:35:27 +08:00 committed by Liam Girdwood
parent 7c4c25e4bc
commit 53a4befa4e
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
drivers/regulator/max8660.c
View File

@ -450,7 +450,7 @@ static int __devinit max8660_probe(struct i2c_client *client,
} }
} }
i2c_set_clientdata(client, rdev); i2c_set_clientdata(client, max8660);
dev_info(&client->dev, "Maxim 8660/8661 regulator driver loaded\n"); dev_info(&client->dev, "Maxim 8660/8661 regulator driver loaded\n");
return 0; return 0;
@ -465,13 +465,13 @@ out:
static int __devexit max8660_remove(struct i2c_client *client) static int __devexit max8660_remove(struct i2c_client *client)
{ {
struct regulator_dev **rdev = i2c_get_clientdata(client); struct max8660 *max8660 = i2c_get_clientdata(client);
int i; int i;
for (i = 0; i < MAX8660_V_END; i++) for (i = 0; i < MAX8660_V_END; i++)
if (rdev[i]) if (max8660->rdev[i])
regulator_unregister(rdev[i]); regulator_unregister(max8660->rdev[i]);
kfree(rdev); kfree(max8660);
return 0; return 0;
} }