hollalinux
/
linux-sg2042
mirror of https://github.com/sophgo/linux-riscv.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

serdev: ttyport: release tty lock sooner on open 

Release the tty lock once tty-driver open returns to make it clear that
it does not protect neither tty->termios or the serport flags.

Signed-off-by: Johan Hovold <johan@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Johan Hovold 2017-11-03 15:30:57 +01:00 committed by Greg Kroah-Hartman
parent 10f9e033c1
commit 51899a63b4
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/tty/serdev/serdev-ttyport.c
View File

@ -104,6 +104,8 @@ static int ttyport_open(struct serdev_controller *ctrl)
if (ret) if (ret)
goto err_close; goto err_close;
tty_unlock(serport->tty);
/* Bring the UART into a known 8 bits no parity hw fc state */ /* Bring the UART into a known 8 bits no parity hw fc state */
ktermios = tty->termios; ktermios = tty->termios;
ktermios.c_iflag &= ~(IGNBRK | BRKINT | PARMRK | ISTRIP | ktermios.c_iflag &= ~(IGNBRK | BRKINT | PARMRK | ISTRIP |
@ -117,7 +119,6 @@ static int ttyport_open(struct serdev_controller *ctrl)
set_bit(SERPORT_ACTIVE, &serport->flags); set_bit(SERPORT_ACTIVE, &serport->flags);
tty_unlock(serport->tty);
return 0; return 0;
err_close: err_close: