hollalinux
/
linux-sg2042
mirror of https://github.com/sophgo/linux-riscv.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

usb: dwc3: exynos: Fix error handling of clk_prepare_enable 

If clk_prepare_enable() fails in dwc3_exynos_probe() or in
dwc3_exynos_resume(), exynos->clks[0] is left undisabled
because of usage preincrement in while condition.

Found by Linux Driver Verification project (linuxtesting.org).

Fixes: 9f2168367a ("usb: dwc3: exynos: Rework clock handling and prepare for new variants")
Acked-by: Marek Szyprowski <m.szyprowski@samsung.com>
Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
This commit is contained in:
Alexey Khoroshilov 2019-01-22 00:23:50 +03:00 committed by Felipe Balbi
parent f2105d4259
commit 512e6fb589
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/usb/dwc3/dwc3-exynos.c
View File

@ -78,7 +78,7 @@ static int dwc3_exynos_probe(struct platform_device *pdev)
for (i = 0; i < exynos->num_clks; i++) { for (i = 0; i < exynos->num_clks; i++) {
ret = clk_prepare_enable(exynos->clks[i]); ret = clk_prepare_enable(exynos->clks[i]);
if (ret) { if (ret) {
while (--i > 0) while (i-- > 0)
clk_disable_unprepare(exynos->clks[i]); clk_disable_unprepare(exynos->clks[i]);
return ret; return ret;
} }
@ -223,7 +223,7 @@ static int dwc3_exynos_resume(struct device *dev)
for (i = 0; i < exynos->num_clks; i++) { for (i = 0; i < exynos->num_clks; i++) {
ret = clk_prepare_enable(exynos->clks[i]); ret = clk_prepare_enable(exynos->clks[i]);
if (ret) { if (ret) {
while (--i > 0) while (i-- > 0)
clk_disable_unprepare(exynos->clks[i]); clk_disable_unprepare(exynos->clks[i]);
return ret; return ret;
} }